Reduce memeory allocations in DocumentRenderer::_renderSkinProperties
---------------------------------------------------------------------
Key: TRINIDAD-963
URL: https://issues.apache.org/jira/browse/TRINIDAD-963
Project: MyFaces Trinidad
Issue Type: Bug
Components: Skinning
Reporter: Jeanne Waldman
Assignee: Jeanne Waldman
this issue was found by Stevan Malesevic
DocumentRenderer::_renderSkinProperties does new StingBuilder inside the
loop. This is bad due to number of string builders allocations and also there
are calls to expand capacity. We should move new StringBuilder outside of the
loop and also move toString() outside of the loop. Also we should try to
estimate the size. Some of the testign I did showed that this works fine:
StringBuilder sb = new StringBuilder(skinProperties.size() * 70);
//loop goes here
out.write(sb.toString());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
