duplicate ids not detected in JspStateManagerImpl.checkForDuplicateIds()
-------------------------------------------------------------------------
Key: MYFACES-1825
URL: https://issues.apache.org/jira/browse/MYFACES-1825
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 1.1.5
Reporter: gaston
Some duplicate id are detected in my MyFaces(1.1.5)/Facelets(1.1.12) based
application.
I think there's a bug in MyFaces's detection of duplicate ids in
JspStateManagerImpl.checkForDuplicateIds() :
this code seems to be wrong :
boolean namingContainer = component instanceof NamingContainer;
while (it.hasNext()) {
UIComponent kid = (UIComponent) it.next();
if (namingContainer) {
checkForDuplicateIds(context, kid, new HashSet());
}
else {
checkForDuplicateIds(context, kid, ids);
}
}
It should be :
while (it.hasNext()) {
UIComponent kid = (UIComponent) it.next();
boolean namingContainer = kid instanceof NamingContainer;
if (namingContainer) {
checkForDuplicateIds(context, kid, new HashSet());
}
else {
checkForDuplicateIds(context, kid, ids);
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
