+1 On Mon, Mar 10, 2008 at 11:33 AM, simon <[EMAIL PROTECTED]> wrote:
> > On Mon, 2008-03-10 at 09:02 +0100, Mario Ivankovits wrote: > > Hi! > > > The tar.gz and zip archives are deployed at [3] > > > > > LICENSE.txt and NOTICE.txt are missing from, at least, the tar.gzarchive. > > +1 when fixed. > > Ok, the assembly.xml file has been tweaked and assemblies regenerated so > the LICENSE and NOTICE are now in the assembly files. The jarfiles in > the staging repos have not been recreated. > > I've also added .sha1 checksums, just for fun. > > And my signing key is now in the myfaces KEYS file, so the sigs on these > files can be verified. > > > > > > > Not so important, but, it looks like these archives are a mixture of > > -bin and -src (which is fine I think), but no class files beside the jar > > are in there, though, the sources are in there packed and unpacked. > > Shouldn't the class files be added there too. > > No, I don't think so. Providing unpacked source is optional; as you > point out the -source jar is already there. But I think people expect to > see a source dir inside the assembly jar. > > Providing unpacked raw .class files doesn't seem very useful to me. > > Regards, > Simon > > -- Grant Smith
