[
https://issues.apache.org/jira/browse/ORCHESTRA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577464#action_12577464
]
Mario Ivankovits commented on ORCHESTRA-17:
-------------------------------------------
If I understand your patch correctly this thing will no longer work with plain
jsp, will it?
Some applications mix jsp and jsf pages, even if the jsp page is just a
"bridge" or something like that. I (we) wanted to support such setup.
But probably I missed some things ;-)
> RequestParameterFacesContextFactory only works with HttpServletResponse
> -----------------------------------------------------------------------
>
> Key: ORCHESTRA-17
> URL: https://issues.apache.org/jira/browse/ORCHESTRA-17
> Project: MyFaces Orchestra
> Issue Type: Bug
> Components: RequestParameterProvider
> Affects Versions: 1.0, 1.1
> Environment: Liferay Portlet Container
> Reporter: Martin Marinschek
> Assignee: Martin Marinschek
>
> The following snippet wrongly casts to HttpServletResponse, therefore
> portlet-environments will not work:
> if (response instanceof HttpServletResponse)
> {
> HttpServletRequest httpServletRequest = (HttpServletRequest)
> request;
>
> // Wrap this request only if something else (eg a
> RequestParameterServletFilter) has not already wrapped it.
> if
> (!Boolean.TRUE.equals(httpServletRequest.getAttribute(RequestParameterServletFilter.REQUEST_PARAM_FILTER_CALLED)))
> {
>
> I will commit a solution very soon.
> regards,
> Martin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
