Hi, I just took a quick glance at the changes in the PPRPhaseListener. What I've seen looks alright so far and since I'm working on that class at the moment anyway I'll be happy to factor in those changes.
As for the DojoUtils, those are as far as I know mainly maintained by werner. Maybe he wants to have a look there - otherwise I'll also take a look at that too. You are absolutely right when you say that our components should also work in portlet environments. thanks for your contribution. cheer Ernst On Mon, Mar 24, 2008 at 2:21 PM, Scott O'Bryan <[EMAIL PROTECTED]> wrote: > Cool beans. Be careful though before checking these patches into a mainline > code base (maybe a sandbox or something). This solution probably won't work > for remote WSRP portals. As for your second suggestion, I couldn't agree > more. The Trinidad configurators provide an ExternalContext specifically to > keep the abstraction container agnostic. You may wish to implement the > ExternalContext in your change. > > Scott > > > > On Mon, Mar 24, 2008 at 5:15 AM, a clem <[EMAIL PROTECTED]> wrote: > > Hi, > > > > I ve made working pprPanelGroup in liferay portal. To do that, I had > > to patch 2 files of the core and sandbox distributions. > > - org/apache/myfaces/custom/dojo/DojoUtils.java > > - org/apache/myfaces/custom/ppr/PPRPhaseListener.java > > > > Basically the modifications consist to check wether the request is a > > portletrequest or a servletrequest. > > It would be nice if ajax related myfaces code could be completely > > servlet or portlet context agnostic, for example using a layer of > > abstraction on top of servlet and portlet apis. > > > > I also had to patch 6 files of the liferay code base to make the > > portal PPR aware. For those who are interested, just let me know. > > It is quite simple but it works nice and it is, I think, a more > > flexible and powerful approach than the IceFaces one to get Ajax > > working within your portlets. > > > >
