Hi

Checking the javascript part of myfaces core i have noted that
HtmlFormRendererBase
has some public methods for add input hidden fields that are rendered before
the end of
a form.

Actually, this api does not work, causing a lot of troubles for:

(form1 is really the id of the form)

autoscroll
h:commandButton (form1:_idcl and form1:_link_hidden_)
h:commandLink (form1:_idcl and form1:_link_hidden_)
t:jscookMenu (add hidden field jscook_action)
s:fishEyeNavigationMenu (use form1:_idcl to send a submit from javascript)

In one part of the code, the hidden fields are added in this way:

  
facesContext.getExternalContext().getRequestMap().put(getHiddenCommandInputsSetName(facesContext,
form), set);

but when it try to render HtmlFormRendererBase do this:

  Set set =
(Set)component.getAttributes().get(HIDDEN_COMMAND_INPUTS_SET_ATTR);

The idea is use one way (use request map) or another (use attributes (looks
better at my eyes)).

I have found an issue for tomahawk that says this:

 MYFACES-1662 : Move autoscroll feature from shared HtmlRendererUtils to
Tomahawk

 Is this jira issue still valid?

In conclusion, the questions are this:

 This api should work on 1.2? If the answer is no, what is the reason?
 Is the issue MYFACES-1662 valid?

regards

Leonardo Uribe

Reply via email to