On Mon, Apr 7, 2008 at 6:43 PM, Matthias Wessendorf <[EMAIL PROTECTED]> wrote:
> On Mon, Apr 7, 2008 at 6:40 PM, Scott O'Bryan <[EMAIL PROTECTED]> wrote:
> > Matthias, the bridge does url rewriting as well, and we ignore anything
> that
> > has a "javascript:" prefix. Basically, queryStrings only make sense on
> > URL's that are http and https (or stuff that resolves to them). I think
> > that orchestra's encodeActionURL needs to be smart enough to handle this
> > case?
>
> yeah, that is an option as well.
> We really (IMO) don't need conversationContext for some client side things...
>
>
> >
> > Why? From a logistical standpoint, in the portal things have to be
> > encoded. Let say we have a tr:goLink that someone assigns to be
> > "javascript:alert('hi);". There should be no reason this wouldn't work,
> yet
> > the go link always encodes it's URL. Should everything that encode's it's
> > URL have to handle all the perepherial cases or should the implementation
> of
> > the encodeActionURL be smart enough to take this into account? I think the
> > latter.
> >
> > Therefore, I would say that orchestra should only append the
> > conversationContext if the protocol is http or https. Or do the opposite
> > (like the bridge does) and look for protocols to exclude like ftp: and
> > javascript:.
>
> +1
>
> I will file an issue for that
http://issues.apache.org/jira/browse/ORCHESTRA-21
>
> -M
>
>
> >
> > Scott
> >
> >
> >
> > Matthias Wessendorf wrote:
> >
> > > Hi,
> > >
> > > when using Trinidad's shuttle within an Orchestra application, the
> > > (re)move buttons are not usable.
> > >
> > > Why ?
> > >
> > > Because Trinidad creates the javascript calls like
> > > String url = "javascript:TrShuttleProxy._moveItems(.......";
> > >
> > > and than, we internally encode the url.
> > > Like facesContext.getExternalContext().encodeActionURL(url);
> > >
> > > so... with Orchestra, you now get something like:
> > > javascript:TrShuttleProxy._movetems(....);?conversationContext=3
> > > which causes a JS syntax error.
> > >
> > > Should we just stop to encode that client side "action" url ?
> > >
> > > -M
> > >
> > >
> > >
> >
> >
>
>
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>
--
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org
