Hi Blake, I wanted to be backwards compatible with what the XSS offered. So I assumed that we's want just a list (not necessarily an interval) And I picked the easiest to parse format.
But it's a good idea to follow a (possible) future standard. I had a quick look over it's syntax, but not enough. Isn't there a way to have a list of numbers? smth like : @agent ie (version: 5 7) @Andrew Currently (and in the XSS format) version is compared with TrinidadAgent.getAgentMajorVersion() it also has a getAgentVersion() method that returns the full unparsed string. I don't know what it means, but I assume it's very browser dependent. But do you see a use-case when you would need different css for minor versions? Like a difference between IE 5.0 and 5.5 ? It would be nice to get to a final conclusion, so I can update this solution before the next release. regards, -- Cristi Toth ------------- Codebeat www.codebeat.ro On Thu, Apr 17, 2008 at 1:14 AM, Blake Sullivan <[EMAIL PROTECTED]> wrote: > Cristi, > > I think that we should follow a subset of the syntax of CSS Media > Queries<http://www.w3.org/TR/css3-mediaqueries/>for consistency as this is a > CSS file. If there are other standard syntaxes > for CSS, we can use one of those instead. > > Your rule below could be expressed in such a syntax as: > > @agent ie and (min-version:5) and (max-version:7), gecko, safari > > Assuming that we chose a convenient definition for ma-version (that it > includes all version up to but not including an increment of the smallest > specified digit. so that max-version:7 really means version < 8, while > max-version 7.5 really means version < 7.6) > > -- Blake Sullivan > > > > Cristi Toth said the following On 4/16/2008 3:24 PM PT: > > Hi guys, > > I finally added browser version support in skinning, but using a different > format than first suggested. > As we needed to support multiple browsers, each with multiple versions, I > have chosen to use this format: > > @ agent ie 5 6 7, gecko,safari {....} > > So each agent definition separated by comma and the versions a space > separated list following the browser type. > > Also in the code I replaced : > int[] browsers > int[] versions > with : > Map <Integer, Set<Integer>> browsers > > this represents browser types mapped to their versions set. > > > If you have any objections on this, please reopen the issue and add some > comments > > Regards, > -- > Cristi Toth > > ------------- > Codebeat > www.codebeat.ro > > >
