Agree with Matzew, action listener way looks better.

It'll also help making it work with client side state saving.

On Sat, Apr 19, 2008 at 11:11 AM, Matthias Wessendorf <[EMAIL PROTECTED]>
wrote:

> On Sat, Apr 19, 2008 at 9:22 AM, Hazem Saleh <[EMAIL PROTECTED]>
> wrote:
> > Hi Matzew,
> > I followed the previous pattern of the excelExport component.
> > So IMO, I think it is not odd for the component users.
>
> well, perhaps personal choice.
>
> Take this:
>
> http://myfaces.apache.org/trinidad/trinidad-api/tagdoc/tr_fileDownloadActionListener.html
>
> that is (somewhat) similar and other libs do it in a similar fashion.
> I don't care that strong,
> but looks like the "old" component did it already... well not correct ;-)
> In sandbox there is a way to change this, outside of sandbox not, but
> do what you want.
> Was just a suggestion ;-)
>
> -M
>
> >
> >
> >
> > On Fri, Apr 18, 2008 at 7:41 PM, Matthias Wessendorf <[EMAIL PROTECTED]>
> > wrote:
> >
> > >
> > > On Fri, Apr 18, 2008 at 7:02 PM, Hazem Saleh <[EMAIL PROTECTED]>
> > wrote:
> > > > Hi Matzew,
> > > > What is the problem with the previous syntax :-
> > > >
> > > > <s:exporter for="<your dataTable id>" fileType="<EXCEL or PDF>">
> > > >     <h:commandButton action="" value="Export"/>
> > > >  </s:exporter>
> > >
> > > I thought that the exporter would be an ActionListener.
> > > Therefore embedding it inside an ActionSource(2) component
> > > would make sense.
> > >
> > > I think it is odd, the nest the button inside a comp, to do the
> export.
> > > Nesting the exporter inside the button makes more sense, since
> > > the button performs the action. So IMO it should be ActionListener.
> > >
> > > -M
> > >
> > >
> > >
> > >
> > >
> > >
> > > >
> > > >
> > > >
> > > > On Fri, Apr 18, 2008 at 6:57 PM, Matthias Wessendorf <
> [EMAIL PROTECTED]>
> > > > wrote:
> > > > > Hi,
> > > > >
> > > > > I would  instead of:
> > > > >
> > > > > <s:exporter for="<your dataTable id>" fileType="<EXCEL or PDF>">
> > > > >    <h:commandButton action="" value="Export"/>
> > > > > </s:exporter>
> > > > >
> > > > > expect something like:
> > > > >
> > > > > <commandButton...>
> > > > >    <s:exporter/>
> > > > > </commandButton>
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On Fri, Apr 18, 2008 at 6:49 PM, Hazem Saleh <
> [EMAIL PROTECTED]>
> > > > wrote:
> > > > > > Hi Team,
> > > > > > Generated file is now depending on the mime type :) .
> > > > > >
> > > > > >  Here is an example of usage)
> > > > > >  <s:exporter for="<your dataTable id>" fileType="<XLS or PDF>">
> > > > > >      <h:commandButton action="" value="Export"/>
> > > > > >  </s:exporter>
> > > > > > Thanks all for your suggestions.
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Fri, Apr 18, 2008 at 5:45 AM, Hazem Saleh <
> [EMAIL PROTECTED]>
> > > > wrote:
> > > > > > > Hi Team,
> > > > > > > Iam pleased to tell you that I integrated both the excelExport
> and
> > the
> > > > > > pdfExport components into
> > > > > > > one single component called (exporter).
> > > > > > >
> > > > > > > Till now, it exports the contents of DataTables to EXCEL or
> PDF
> > files.
> > > > > > >
> > > > > > > Here is an example of usage)
> > > > > > > <s:exporter for="<your dataTable id>" fileType="<EXCEL or
> PDF>">
> > > > > > >     <h:commandButton action="" value="Export"/>
> > > > > > > </s:exporter>
> > > > > > >
> > > > > > > Here is the patch URL:
> > > > > > > https://issues.apache.org/jira/browse/TOMAHAWK-1231
> > > > > > >
> > > > > > > Thanks all very much.
> > > > > > > --
> > > > > > > Hazem Ahmed Saleh Ahmed
> > > > > > > http://www.jroller.com/page/HazemBlog
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Hazem Ahmed Saleh Ahmed
> > > > > > http://www.jroller.com/page/HazemBlog
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > sessions: http://www.slideshare.net/mwessendorf
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > >
> > > > Hazem Ahmed Saleh Ahmed
> > > > http://www.jroller.com/page/HazemBlog
> > >
> > >
> > >
> > > --
> > >
> > >
> > >
> > > Matthias Wessendorf
> > >
> > > further stuff:
> > > blog: http://matthiaswessendorf.wordpress.com/
> > > sessions: http://www.slideshare.net/mwessendorf
> > > mail: matzew-at-apache-dot-org
> > >
> >
> >
> >
> > --
> >
> > Hazem Ahmed Saleh Ahmed
> > http://www.jroller.com/page/HazemBlog
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>

Reply via email to