[ https://issues.apache.org/jira/browse/MYFACES-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597076#action_12597076 ]
Simon Kitching commented on MYFACES-434: ---------------------------------------- This patch doesn't work with Orchestra 1.1 release. The problem is that this introduces a custom TomahawkFacesContextFactory that is *always* installed automatically when tomahawk is in the classpath. And Orchestra does the same. But the orchestra FacesContextWrapper instances that the factory creates are package-scoped, so reflection calls by the new tomahawk wrapper fail. I'll change orchestra to make its FacesContextWrapper class public. But it does show the danger of custom FacesContextFactory classes. There are also a number of nasty issues related to wrapping of FacesContextFactory. See: MYFACES-1820 > MyFaces's Portlet enhancement > ----------------------------- > > Key: MYFACES-434 > URL: https://issues.apache.org/jira/browse/MYFACES-434 > Project: MyFaces Core > Issue Type: Improvement > Components: Portlet_Support > Affects Versions: 1.1.0 > Environment: LInux, J2SE 1.4.2 > Reporter: Shinsuke SUGAYA > Assignee: Martin Marinschek > Fix For: 1.1.6-SNAPSHOT > > Attachments: PortletEnableTomahawk.patch, tomahawk-patch-portlet.zip, > Tomahawk_FileUpload_IBMPortal.zip > > > MyFacesGenericPortlet does not fully support the feature of tomahawk > component, such as inputHtml and fileUpload. So, I request the following > feature to run it on portlet: > - support tags in <head> (ex. inputHtml component) > - support upload (fileUpload component) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.