Hi,

Currently the myfaces master pom checkstyle configuration points
directly at our subversion repository:

 <plugin>
   <groupId>org.apache.maven.plugins</groupId>
   <artifactId>maven-checkstyle-plugin</artifactId>
   <version>2.1</version>
   <configuration>
<!-- TODO: FIX THIS!
  -
  - Referencing resources directly from svn is very bad.
  - Firstly, it needs network access to build anything.
  - But worse, if this pom is released with this here,
  - then svn cannot be reorganised to move these files
  - without breaking any builds that use that released
   - pom. Which means the svn directory structure is
  - effectively "locked" in place for years.
  -->

   <configLocation>
 http://svn.apache.org/repos/asf/myfaces/
   myfaces-master-pom/trunk/checkstyle/
    default/myfaces-checks.xml
   </configLocation>
   <headerLocation>
  http://svn.apache.org/repos/asf/myfaces/
  myfaces-master-pom/trunk/checkstyle/
   default/myfaces-header.txt
   </headerLocation>
   </configuration>
 </plugin>

The comment is mine, having discovered that the old and completely
obsolete directory 
  http://svn.apache.org/repos/asf/myfaces/maven/trunk/
cannot be deleted because older releases of the master pom like this
one:
 http://svn.apache.org/repos/asf/myfaces/
  myfaces-master-pom/tags/myfaces-5/pom.xml
point to
 http://svn.apache.org/repos/asf/myfaces/maven/trunk/
   build-tools/src/main/resources/config/myfaces-checks.xml


I would like to fix this crazy setup by following the "multimodule
setup" as described here:

http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html

This means creating a new project under myfaces-build-tools that
contains our checkstyle rules, then following a normal release cycle for
it.

An alternative I tried was to use "svn peg revisions" to try to point to
a file in a specific version of the svn repo but that doesn't seem to
work via the svn web interface, just with the svn commandline tool. And
anyway it still leaves us needing internet connectivity to run
checkstyle.

Are there any objections? If not, I'll try to implement that later this
week.

Regards,
Simon

Reply via email to