"Show all" option should be optional for table range navigation, as it breaks 
lazy data models
----------------------------------------------------------------------------------------------

                 Key: TRINIDAD-1122
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1122
             Project: MyFaces Trinidad
          Issue Type: Improvement
          Components: Components
    Affects Versions:  1.2.8-core
            Reporter: Alex Savitsky


When a table with "rows" attribute is rendered, it also renders the range 
navigation controls. This control includes a drop-down list that allows user to 
navigate to any page in the data model that backs the table. Currently, the 
first option in this range navigator is the "show all X records" option, and 
there's no way to disable it. When using range navigation with lazy-loading 
data models (backed by a Seam EntityQuery, for example), the "show all" option 
is very harmful, as users might inadvertently request for all, say, 1 million 
records to be shown, possibly even bringing down the JVM.

Personally, I'd rather not have this option at all (all it took me was to 
modify the 
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.TableRenderer.NavBar.showAllSupported()
 to return false), but the real (and better) fix would be to have an attribute 
to the table control that would trigger rendering "show all" on or off.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to