[ 
https://issues.apache.org/jira/browse/TRINIDAD-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615378#action_12615378
 ] 

Scott O'Bryan commented on TRINIDAD-1109:
-----------------------------------------

Yeah, this could get messy.  Ideally the skins would be written, by default, to 
conform to the most widely used interpretation of the spec, but that's 
debatable as to what that is and I know many of the skins today assume FF as 
the base with a few IE extensions...

I do like the concept though.  I suppose we could add an unknown agent (I 
actually think we have one - do a source code search for Opera) and then if 
people report any issues against the unknown skins, we can either fix them and 
make FF skins as appropriate or say, hey, that browser is unsupported.  Maybe 
then it would encourage people to add more browsers.

Scott

> Support non-standard user agents
> --------------------------------
>
>                 Key: TRINIDAD-1109
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1109
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions:  1.0.8-core,  1.2.8-core
>         Environment: User agent string: Mozilla/5.0 (compatible; 
> Konqueror/3.5; Linux) KHTML/3.5.9 (like Gecko)
>            Reporter: Alexey Stukalov
>
> Trinidad should be able to render the request for non-supported user agents.
> Since 1.x.9 version, user agent's version is mandatory.
> If user agent is not recognized and its version is not set, exceptions are 
> thrown:
>   1) on initial request - "version must be non-null" NPE in 
> org.apache.myfaces.trinidad.context.Version._checkNonEmptyString(Version.java:197)
>   2) on subsequent requests - NPE in 
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$Key.hashCode(FileSystemStyleCache.java:1131)
> The proposed policy is to provide "default" rendering for those agent's that 
> are not recognized/partially recognized (agent type or platform identified, 
> but not version etc).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to