On Wed, Jul 30, 2008 at 7:51 AM, Simon Kitching <[EMAIL PROTECTED]>wrote:
> Leonardo Uribe schrieb: > >> >> The change done before was instead create input hidden fields rendering >> using html for each param on h:commandLink, use javascript for create and >> remove this fields (see the arguments on MYFACES-1855). >> >> I can see the problem when id is used as param name on IE (on firefox >> works well). But I think that a better solution is do some javascript >> modification instead go back to old and "source of incompatibilities" code. >> > Hmm..is using javascript here really the right thing to do? > > I know that someone at Irian was putting work into rendering an > h:outputLink as a submit-button with CSS to make it look like a link, so > that h:commandLink could be used without javascript. And that seems like a > nice feature to have. > Are you talking about MYFACES-1692, or is other different comment? > > But if we now start using javascript to pass the link params back to the > server, then a commandLink without javascript becomes impossible. > Really not, since we do not change HtmlFormRendererBase (the guy that render hidden fields, but think about if someone uses other different form component. Since this renderer put the hidden fields, all components depending on this behavior (some tomahawk components) becames incompatible (trinidad has its own renderer) ). After looking about a solution for MYFACES-1692, my personal conclusion was let it as is. Unfortunately, the fact is that h:commandLink needs javascript to work. > > Which way should we be heading with this? > Suggestion are welcome. Checking the javascript code the problem on IE is present when it try to do this: form.elements['id'] IE returns its form id, but Firefox returns the correct child. One possible solution is do this in the old way when param name="id". But I don't think that jsf ri don't have the same problem too. Maybe other solution more friendly is create a web.xml config param like org.apache.myfaces.RENDER_PARAMS_HIDDEN_FIELDS, to active the old way instead. regards Leonardo Uribe > > Regards, Simon > >
