-0
The pom still has some of the old checkstyle config in, which points to
a location within our svn system.
<configLocation>
http://svn.apache.org/repos/asf/myfaces/maven/trunk/build-tools/src/main/resources/config/myfaces-checks.xml
</configLocation>
−
<headerLocation>
http://svn.apache.org/repos/asf/myfaces/maven/trunk/build-tools/src/main/resources/config/myfaces-header.txt
</headerLocation>
This means that the site (including project reports) cannot be built
without internet access, and that if that svn directory ever gets
deleted, then the site cannot be built at all.
Being able to repeatedly build the site and reports without hacking the
pom is not absolutely critical, so I'm -0 rather than -1. But it would
be nice to get this fixed.
Other trivial note:
"an environment that will be common"
--> "an environment that is common" ?
And you have a repo defined for here:
http://myfaces.zones.apache.org/dist/maven-repository
Interesting, I didn't know it existed. Doesn't look like anyone else
knows it exists either, as the only files in there are *very* old. I
guess that definition doesn't do any harm, but it is a little confusing,
and pointless AFAIK. If this were a snapshot-repo definition then it
might be useful, but I cannot imagine any case where we would not put
our releases up onto the central repo.
Regards,
Simon
On Thu, 2008-08-14 at 12:03 +0200, Matthias Wessendorf wrote:
> +1
>
> On Thu, Aug 14, 2008 at 11:46 AM, Scott O'Bryan <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
> > I'm trying to release the MyFaces Portlet Bridge Master POM v2. This pom
> > file was created in order to support the latest portlet-bridge project's
> > website as well as the multiple open code lines needed for this project
> > going forward. This file manages the commonalities between all of the
> > Portlet Bridge projects and is derived off of the MyFaces Master POM v. 6.
> >
> > I was running the needed tasks to get the v2 release of the Apache MyFaces
> > Portlet Bridge Master pom out. The artifacts are deployed to my private
> > Apache account ([1]).
> >
> > Please take a look at the "portlet-bridge-master-pom-1" artifacts and vote
> >
> > ------------------------------------------------
> > [ ] +1 for community members who have reviewed the bits
> > [ ] +0
> > [ ] -1 for fatal flaws that should cause these bits not to be released,
> > and why..............
> > ------------------------------------------------
> >
> > Thanks,
> > Scott
> >
> > [1]
> > http://people.apache.org/~sobryan/portlet-bridge/portlet-bridge-master-pom-2/
> >
>
>
>
