[ 
https://issues.apache.org/jira/browse/TOMAHAWK-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632275#action_12632275
 ] 

Romain Seguy commented on TOMAHAWK-1331:
----------------------------------------

I've sucessfully tested the patch on my env. Works fine. Thanks for it.

> ExternalContextUtils.getRequestType() doesn't work in a portlet environment
> ---------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1331
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1331
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Portlet_Support
>    Affects Versions: 1.1.7
>         Environment: WebSphere Portal 6.0
> MyFaces 1.1.6
> Tomahawk 1.1.7
> Portals Bridges 1.0.4
>            Reporter: Romain Seguy
>         Attachments: TOMAHAWK-1331.log, TOMAHAWK-1331.patch
>
>
> ExternalContextUtils.getRequestType(Object config, Object request) signature 
> doesn't correspond to what's used in 
> TomahawkFacesContextFactory.getFacesContext(): The called method requires a 
> config and a request while it's invoked using a context and a request.
> ==> This always leads to a ClassCastException at 
> TomahawkFacesContextFactory.getFacesContext()#64.
> The invoked method seems to have to be fixed something like this:
> class ExternalContextUtils:
> public static final RequestType getRequestType(Object context, Object 
> request) {
>         if(_PORTLET_CONTEXT_CLASS != null)
>         {
>             if (_PORTLET_CONTEXT_CLASS.isInstance(context))
>             {
>                 // blablabla
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to