[
https://issues.apache.org/jira/browse/TOMAHAWK-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633379#action_12633379
]
Paul Rivera commented on TOMAHAWK-1335:
---------------------------------------
I've attached a patch for this above. The patch just removes this line from
SelectOneRowRenderer:
- HtmlRendererUtils.renderHTMLAttributes(writer, row, new
String[]{HTML.ONCLICK_ATTR});
No need for this because ONCLICK_ATTR is already in
HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED.
I've checked for both myfaces shared 2.0.x and 3.0.x. This is how ONCLICK_ATTR
is included in HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED:
MYFACES SHARED 2.0.x
INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED
INPUT_ATTRIBUTES,
ALIGN_ATTR,
ALT_ATTR,
CHECKED_ATTR,
DATAFLD_ATTR,
DATASRC_ATTR,
DATAFORMATAS_ATTR,
MAXLENGTH_ATTR,
READONLY_ATTR,
SIZE_ATTR,
AUTOCOMPLETE_ATTR
COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED);
COMMON_PASSTROUGH_ATTRIBUTES,
EVENT_HANDLER_ATTRIBUTES,
EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONCLICK,
new String[] {ONCLICK_ATTR}); --------------------------> onclick
already here!
UNIVERSAL_ATTRIBUTES);
COMMON_FIELD_ATTRIBUTES_WITHOUT_DISABLED,
COMMON_FIELD_EVENT_ATTRIBUTES);
MYFACES SHARED 3.0.x
INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED
INPUT_ATTRIBUTES,
ALIGN_ATTR,
ALT_ATTR,
CHECKED_ATTR,
MAXLENGTH_ATTR,
READONLY_ATTR,
SIZE_ATTR
COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED);
COMMON_PASSTROUGH_ATTRIBUTES,
EVENT_HANDLER_ATTRIBUTES,
EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONCLICK,
new String[] {ONCLICK_ATTR}); --------------------------> onclick
already here!
UNIVERSAL_ATTRIBUTES);
COMMON_FIELD_ATTRIBUTES_WITHOUT_DISABLED,
COMMON_FIELD_EVENT_ATTRIBUTES);
> onclick attribute rendered twice for selectOneRow
> -------------------------------------------------
>
> Key: TOMAHAWK-1335
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1335
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Affects Versions: 1.1.8-SNAPSHOT
> Environment: tomahawk-1.1.8-SNAPSHOT
> myfaces 1.1.7-SNAPSHOT
> tomahawk 6.0.16
> java 1.6.0
> Reporter: Paul Rivera
> Priority: Minor
> Attachments: SelectOneRowRenderer.patch
>
>
> onclick attribute for selectOneRadio is rendered twice.
> here's my sample jsf:
> <h:dataTable var="item" value="#{selectOneBean.data}">
> <h:column>
> <t:selectOneRow onclick="someFunc()"/>
> </h:column>
> <h:column>
> <h:outputText value="#{item}"/>
> </h:column>
> </h:dataTable>
> here's my sample bean:
> public class SelectOneBean
> {
> ArrayList data;
>
> public SelectOneBean() {
> data = new ArrayList();
> data.add("mars");
> data.add("jupiter");
> data.add("neptune");
> data.add("mercury");
> }
> public ArrayList getData()
> {
> return data;
> }
> }
> The html generated looks like this:
> <input type="radio" name="" id="_idJsp0:0:_idJsp2" value="_idJsp0:0:_idJsp2"
> onclick="someFunc()" onclick="someFunc()" /></td><td>mars</td></tr>
> There is no loss of functionality here, though. The javascript function will
> still get called (once).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
