[ 
https://issues.apache.org/jira/browse/MYFACES-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635941#action_12635941
 ] 

Leonardo Uribe commented on MYFACES-1976:
-----------------------------------------

After checking this issue in deep (and do some work on bugs related to shared) 
the big reasons about why do that was clear (I didn't remember why do this).

 The actual behavior unpack shared sources and .class files on myfaces, so when 
the IDE open the project (for example using eclipse), the developer can see a 
source path called shared_sources. If it was a dependency only on snapshot 
build, when someone wants to see where this code comes from he/she see the 
shared dependency and for modifications goes to shared-impl project and then to 
shared-code (where the real code is). Do this makes easier to the user where 
the code comes from.

 Also, when a developer is running an app using maven jetty plugin, if a change 
in shared is done, it is necessary to compile shared-core, shared-impl and 
myfaces impl (because the code needs to be unpacked again for include the 
change). If we have a dependency only on snapshot build instead unpack the 
code, just a compile on shared core and impl it is necessary to check the 
change, so it makes a little bit faster the development.

 The only drawback doing this is that the release manager must compile the 
sources before release adding the property -DperformRelease=true, but since it 
is not a very common task it is ok.

If no objections, I'll commit the necessary changes on myfaces core 1.1 and 1.2.



> Enhance build process, unpacking shared only when a release occur and use a 
> dependency to shared instead
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-1976
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1976
>             Project: MyFaces Core
>          Issue Type: Task
>            Reporter: Leonardo Uribe
>         Attachments: MYFACES-1976-jsf11.patch
>
>
> It could be good use maven profiles to unpack shared sources and add to 
> myfaces core impl jar only when a release occur, and on snapshot version use 
> a dependency to shared jar instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to