[ 
https://issues.apache.org/jira/browse/TRINIDAD-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639584#action_12639584
 ] 

Jeanne Waldman commented on TRINIDAD-636:
-----------------------------------------

make sure to update the skinning.xml file when this is fixed, since the 
documentation now mentions this limitation.
Also, this issue is related to  TRINIDAD-17. We can probably more easily fix 17 
after this issue is fixed.

> Skinning an icon does not pick up base skin's non-overridden properties
> -----------------------------------------------------------------------
>
>                 Key: TRINIDAD-636
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-636
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>            Reporter: Jeanne Waldman
>            Priority: Minor
>
> Skinning an icon does not pick up base skin's non-overridden properties.
> Skinning a style does pick up the base skin's non-overridden properties.
> This is inconsistent.
> Let's say the purple skin has this in it:
> af|selectOrderShuttle::reorder-up-icon {
>       content: url(/skins/purple/images/shuttleOrderUp.png);
>       width: 16px;
>       height: 16px;
>   border: 2px black solid;
> }
> And the skin writer wants to override the icon. He'd probably do this:
> af|selectOrderShuttle::reorder-up-icon {
>       content: url(/skins/purple/images/prev.png);
> }
> and the skin writer would expect the width/height/border to be picked up as 
> they do when you skin "styles".
> What actually happens, however, that the icon is overridden completely. None 
> of the base skin's icon's non-overridden attributes are picked up.
> The styles and the icons should work consistently. Everyone is familiar with 
> how you extend styles, so icons should work the same way.
> I know this is not a simple task to implement, and it isn't critical to fix, 
> but it should be tracked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to