[
https://issues.apache.org/jira/browse/TOMAHAWK-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639715#action_12639715
]
Leonardo Uribe commented on TOMAHAWK-1355:
------------------------------------------
A fast check to 1.1.6 code:
public boolean isReplaceIdWithLabel()
{
if (_replaceIdWithLabel != null) return
_replaceIdWithLabel.booleanValue();
ValueBinding vb = getValueBinding("replaceIdWithLabel");
Boolean v = vb != null ? (Boolean)vb.getValue(getFacesContext()) : null;
return v != null ? v.booleanValue() : false;
}
In 1.1.6 the default is false. But this is strange, cheching the old tag class:
protected void setProperties(UIComponent component)
{
super.setProperties(component);
setStringProperty(component, "summaryFormat", _summaryFormat);
setStringProperty(component, "detailFormat", _detailFormat);
setStringProperty(component, UserRoleAware.ENABLED_ON_USER_ROLE_ATTR,
_enabledOnUserRole);
setStringProperty(component, UserRoleAware.VISIBLE_ON_USER_ROLE_ATTR,
_visibleOnUserRole);
setBooleanProperty(component,
"replaceIdWithLabel",_replaceIdWithLabel==null?Boolean.TRUE.toString():_replaceIdWithLabel);
setBooleanProperty(component, "forceSpan",_forceSpan
==null?Boolean.FALSE.toString():_forceSpan);
}
The default is true (the value it is never null). So, it seems an typo error,
but the documentation says that its default value is true, so it should be
changed.
> t:message(s) replaceIdWithLabel defaults to false in Tomahawk 1.1.7
> -------------------------------------------------------------------
>
> Key: TOMAHAWK-1355
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1355
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Message(s)
> Affects Versions: 1.1.7
> Reporter: Taro App
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Up until Tomahawk 1.1.6, replaceIdWithLabel defaulted to true for t:message
> and t:messages. In Tomahawk 1.1.7, however, replaceIdWithLabel="true" needs
> to be specified explicitly to make this function work, because it defaults to
> false. TLD still says it default to true.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
