On Wed, Nov 12, 2008 at 11:06 AM, Simon Kitching <[EMAIL PROTECTED]>wrote:
> Previously the shared lib was marked as a "provided" dependency, and the > shared code was physically copied into the project on each build. > > Someone (I think it was Leonardo) made changes recently to try to make > development on myfaces easier, so that when building core maven didn't > have to copy over the sources from the shared lib, and only did that > when an actual release build was made. This was announced on the list, > although not much discussion occurred. > Yes, It was me. see MYFACES-1976 > > But it looks like there is a second step that needs to be made: in > release builds the pom also has to avoid having the standard dependency. > Maybe a maven profile could be used here, so developers can do: > mvn -Pdev clean install > which causes the pom to use a standard compile-scope dependency and skip > source import, while > mvn clean install > will cause the shared sources to be imported, and the compile-scope > dependency to be excluded. > Use a profile sounds good. I'll look this issue in deep and made necessary changes. regards Leonardo Uribe > > Cheers, > Simon > > Manfred Geiler schrieb: > > since classes are copied into the myfaces-impl jar, there should not > > be any dependency at all. > > but, to force maven to build myfaces-shared-impl first there should be > > a fake "provided" dependency. > > AFAIR this was the case. I wonder if someone has modified/added this > > dependency lately? > > > > --Manfred > > > > > > On Wed, Nov 12, 2008 at 4:27 PM, Bruno Aranda <[EMAIL PROTECTED]> > wrote: > > > >> If it is not the case, the myfaces-shared-impl should be marked as > >> 'optional' in the impl pom.xml? > >> > >> Bruno > >> > >> 2008/11/12 Cagatay Civici <[EMAIL PROTECTED]> > >> > >>> When I add myfaces-imp 1.2.5 to my pom as a dependency, > >>> myfaces-shared-impl-3.0.5.jar also implicitly added to the classpath. > >>> > >>> It is a problem for myfaces users since now we have the same classes > added > >>> twice to the classpath. > >>> > >>> Cagatay > >>> > >> > > > > > > > -- > -- Emails in "mixed" posting style will be ignored > -- (http://en.wikipedia.org/wiki/Posting_style) > >
