Hi Nishi,

I see you have attached your patch to the MYFACES-1347 issue. So you
just need to wait for one of the people with commit rights to review the
patch and commit it.

Sending a reminder to this list every week or two is ok, but don't do it
too frequently. People are busy (particularly over christmas) so
reviewing patches can take time.

I do see that you have attached a *complete* copy of the new .java file
to the jira issue. Attaching a patch-file (ie the output of "svn diff")
is easier to review. And attaching a .jar file is not useful; nobody
should ever run a jarfile from an unknown source.

Regards,
Simon

On Tue, 2009-01-06 at 16:37 -0500, [email protected] wrote:
> 
> Hi, 
> 
> I fixed the issue MyFaces-1347 by implementing writeObject and
> readObject method in FacesMessage class. 
> 
> How do I check in this file to SVN repository? 
> 
> Kindly advice, 
> 
> Thanks and Regards, 
> Nishi 
> 
> 
> ____________________________________________________________________________________________________________________
> Nishi, CISSP CISA | Advisory | PricewaterhouseCoopers | Telephone: +1
> 732 647 5773 | Facsimile: +1 813 639 3572 | [email protected] 
> 
> Print less, think more. 
> 
> 
> 
> 
> Nishi Shah/US/FAS/p...@americas-us 
> 
> 12/30/2008 07:35 PM 
> 
>          Please respond to
>        "MyFaces Development"
>      <[email protected]>
> 
> "Reply to All" is Disabled 
> 
> 
>                To
> [email protected] 
>                cc
> 
>           Subject
> Re: [jira]
> Updated:
> (MYFACES-1347)
> javax.faces.application.FacesMessage cannot be serialized
> 
> 
> 
> 
> 
> 
> Hello Devs, 
> 
> How do I check in code for this bug fix? 
> https://issues.apache.org/jira/browse/MYFACES-1347
> 
> 
> Kindly advise, 
> 
> Thanks and Regards, 
> Nishi 
> 
> ____________________________________________________________________________________________________________________
> Nishi, CISSP CISA | Advisory | PricewaterhouseCoopers | Telephone: +1
> 732 647 5773 | Facsimile: +1 813 639 3572 | [email protected] 
> 
> Print less, think more. 
> 
> 
> 
> "Nishidhdha (JIRA)"
> <[email protected]> 
> 
> 12/29/2008 03:50 PM 
> 
> 
> "Reply to All" is Disabled 
> 
> 
> 
>                To
> Nishi
> Shah/US/FAS/p...@americas-us 
>                cc
> 
>           Subject
> [jira] Updated:
> (MYFACES-1347)
> javax.faces.application.FacesMessage cannot be serialized
> 
> 
> 
> 
> 
> 
> 
> 
>  [ 
> https://issues.apache.org/jira/browse/MYFACES-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>  ]
> 
> Nishidhdha updated MYFACES-1347:
> --------------------------------
> 
>   Status: Patch Available  (was: Open)
> 
> > javax.faces.application.FacesMessage cannot be serialized
> > ---------------------------------------------------------
> >
> >                 Key: MYFACES-1347
> >                 URL:
> https://issues.apache.org/jira/browse/MYFACES-1347
> >             Project: MyFaces Core
> >          Issue Type: Bug
> >            Reporter: Val Blant
> >
> > javax.faces.application.FacesMessage is declared serializable as it
> should be, but its top level inner memeber class Severity is not
> serializable. As a result FacesMessage cannot be serialized, which
> means that no objects that contain a FacesMessage can be serialized
> 


Reply via email to