[
https://issues.apache.org/jira/browse/TRINIDAD-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668267#action_12668267
]
Graeme Steyn commented on TRINIDAD-1109:
----------------------------------------
I have found that this NPE is occuring on a regular basis for our site when the
following agents try to connect:
Mozilla/5.0 (compatible; Yahoo! Slurp;
http://help.yahoo.com/help/us/ysearch/slurp)
Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)
Mozilla/5.0 (compatible; Charlotte/1.1; http://www.searchme.com/support/)
There was mention of a change related to the googlebot in TRINIDAD-1146 that
has fixed the NPE for the following user agent value:
googlebot/2.1 (+http://www.googlebot.com/bot.html) (forced this agent string
via FireFox switch agent plugin for testing).
Should TRINIDAD-1146 be re-opened? Is there an easy way to exclude common bots
to prevent the NPE?
> Support non-standard user agents
> --------------------------------
>
> Key: TRINIDAD-1109
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1109
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 1.0.8-core, 1.2.8-core
> Environment: User agent string: Mozilla/5.0 (compatible;
> Konqueror/3.5; Linux) KHTML/3.5.9 (like Gecko)
> Reporter: Alexey Stukalov
>
> Trinidad should be able to render the request for non-supported user agents.
> Since 1.x.9 version, user agent's version is mandatory.
> If user agent is not recognized and its version is not set, exceptions are
> thrown:
> 1) on initial request - "version must be non-null" NPE in
> org.apache.myfaces.trinidad.context.Version._checkNonEmptyString(Version.java:197)
> 2) on subsequent requests - NPE in
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$Key.hashCode(FileSystemStyleCache.java:1131)
> The proposed policy is to provide "default" rendering for those agent's that
> are not recognized/partially recognized (agent type or platform identified,
> but not version etc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
