Golden file test framework does not support javax.faces componentTypes
----------------------------------------------------------------------
Key: TRINIDAD-1388
URL: https://issues.apache.org/jira/browse/TRINIDAD-1388
Project: MyFaces Trinidad
Issue Type: Bug
Affects Versions: 1.0.10-core, 1.2.10-core
Reporter: Cale Scholl
Priority: Minor
When a page contains Trinidad components, h:form will be overridden (rendered
with Trinidad HtmlFormRenderer). If there are any changes in how we override
the h:form component in the future, we want to catch this by adding a golden
file test. I tried adding the following test .xml file:
<test xmlns="http://myfaces.apache.org/trinidad/test";
xmlns:tr="http://myfaces.apache.org/trinidad";
xmlns:h="http://java.sun.com/jsf/html";>
<base-component tr:type="javax.faces.component.html.HtmlForm"/>
<!-- javax.faces.Form also does not
work -->
<js-test/>
<attribute-test name="styleClass" value="EmptyPage"/>
</test>
but running "mvn install" gives me a NPE in
oracle.adfinternal.view.faces.renderkit.rich.RichRenderKitTest. According to
http://wiki.apache.org/myfaces/Trinidad_RenderKit_test_framework, we have:
"The type of the component is defined by tr:type, which must match a
componentType value. (NOTE: javax.faces componentTypes are not supported!)"
It would be nice if javax.faces componentTypes were supported, so that we could
add golden file tests for javax.faces components that are overridden by the
Trinidad renderer.
NOTES:
CoreRenderer is used for the javax Form, Button and Link components. See this
code:
trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java:
private void _modifyBasicHTMLRenderKit()
{
// We render UIForms with our own renderer
addRenderer(UIForm.COMPONENT_FAMILY,
"javax.faces.Form",
new HtmlFormRenderer());
...
As you can see, we use the Trinidad HtmlFormRenderer to render h:form (HtmlForm
component).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
