I agree. I wasn't too concerned about the test failures themselves, I
needed to create the impl and factory impl for partial view context
anyway in order to complete the todo's for FacesContext. It was more of
an FYI in case someone else wanted to jump in that I was already working
on it. If it helps the testcases pass it'll really just be a bonus
right now.
Mike
Werner Punz wrote:
Actually I would not worry too much about failing test before we are
feature complete, which we clearly are not yet...
I know we are different to Morjarra in this respect because they simply
enhanced the old RI codebase while trying to stay functional and
trying to keep a working codebase, but they could operate within the
boundaries of always having the latest specs, which we haven´t had up
until this point!
:-)
Just my 2c
Werner
Michael Concini schrieb:
Without seeing the underlying I believe many of those failures may be
due to there not currently being a PartialViewConextImpl or
PartialViewContextFactoryImpl. I noticed this while working on issue
2198 to finish some of the FacesContextImpl todo's. While I'm
updating FacesContextImpl I'm also working up initial versions of the
above two classes based on the last draft spec.
I should have a patch for all by EOD Friday, if not today depending
on other work interruptions.
Leonardo Uribe wrote:
Hi
With the patch on MYFACES-2151 I see this:
Failed tests:
testClassPath(org.apache.myfaces.test.ImplClassElementTestCase)
testRequestParams4(org.apache.myfaces.context.RenderPhaseClientIdsTest)
testRequestParams5(org.apache.myfaces.context.RenderPhaseClientIdsTest)
testRequestParams6(org.apache.myfaces.context.RenderPhaseClientIdsTest)
testRequestParams2(org.apache.myfaces.context.RenderPhaseClientIdsTest)
testRequestParams1(org.apache.myfaces.context.RenderPhaseClientIdsTest)
testOrderingConfig(org.apache.myfaces.config.impl.digister.DigesterFacesConfig
UnmarshallerImplTest)
testNoEntry(org.apache.myfaces.context.TestIsAjaxRequest)
testEntry(org.apache.myfaces.context.TestIsAjaxRequest)
testRequestParams4(org.apache.myfaces.context.ExecutePhaseClientIdsTest)
testRequestParams5(org.apache.myfaces.context.ExecutePhaseClientIdsTest)
testRequestParams6(org.apache.myfaces.context.ExecutePhaseClientIdsTest)
testRequestParams2(org.apache.myfaces.context.ExecutePhaseClientIdsTest)
testRequestParams1(org.apache.myfaces.context.ExecutePhaseClientIdsTest)
testRenderAll1(org.apache.myfaces.context.IsRenderedTest)
Tests run: 156, Failures: 15, Errors: 0, Skipped: 0
This are the test that really are failing right now. The others
fails because we don't have a shale-test for 2.0.
regards
Leonardo Uribe
On Thu, Apr 16, 2009 at 3:59 AM, Werner Punz <[email protected]
<mailto:[email protected]>> wrote:
Matthias Wessendorf schrieb:
Hello,
I did a quick run of the myfaces 2.0, after all the commits.
Now I am
getting this:
Tests run: 168, Failures: 49, Errors: 0, Skipped: 18
Is it only my ubuntu env ? Or do others see that too ?
.M
I have not checked the latest java commits, since my work
currently is only on the javascript side of things, but we used to
have a test problem because the shale unit tests could not be
applied to the jsf2 codebase, I am not sure if this problem has
been resolved so far.
Werner
