[
https://issues.apache.org/jira/browse/TRINIDAD-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713991#action_12713991
]
Matthias Weßendorf commented on TRINIDAD-983:
---------------------------------------------
Thanks for the patch!
However, I have one comment so far;
Can you please update your __getLocale() ?
RequestContext.getFormatingLocale() (if present) is usually used.
viewRoot().getLocale() is only used when the above is not present;
See this snippet from one of our converters;
RequestContext reqContext = RequestContext.getCurrentInstance();
if (reqContext != null)
{
locale = reqContext.getFormattingLocale();
}
if (locale == null)
{
locale = facesContext.getViewRoot().getLocale();
}
Other than that, this looks good so far;
> Sortable model for localized texts
> ----------------------------------
>
> Key: TRINIDAD-983
> URL: https://issues.apache.org/jira/browse/TRINIDAD-983
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Affects Versions: 1.0.6-core
> Reporter: Tomas Havelka
> Attachments: locale-sensitive-sortable-model.patch
>
>
> Sortable model should support sorting for current locale.
> Solution:
> Extend inner class Comp of SortableModel to support sorting of String values
> using Collator.compare method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
