[
https://issues.apache.org/jira/browse/TOMAHAWK-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717129#action_12717129
]
Leonardo Uribe commented on TOMAHAWK-1381:
------------------------------------------
Updated patch TOMAHAWK-1381-fileupload6.patch and committed this one. Reviewed
to work in portlets, fixed case when two input fileupload are used on a single
form and an file size exception occur, fixed problem with ignored getLabel
property on core12.
> HtmlInputFileUpload does not fail gracefully when filesize exceeds
> uploadMaxFileSize web.xml value
> --------------------------------------------------------------------------------------------------
>
> Key: TOMAHAWK-1381
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1381
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: File Upload
> Affects Versions: 1.1.7, 1.1.8
> Reporter: Phillip Webb
> Fix For: 1.1.9-SNAPSHOT
>
> Attachments: file-upload.patch, file-upload2.patch,
> TOMAHAWK-1381-fileupload6.patch
>
>
> When uploading a file using the HtmlInputFileUpload that exceeds that
> uploadMaxFileSize web.xml setting the system fails without error and no form
> data is not processed by JSF.
> I think that there are a number of reasons for this:
> - There is a bug in commons-fileupload that prevents failures from being
> handled correctly (see FILEUPLOAD-169)
> - MultipartRequestWrapper calls FileUploads setSizeMax, this is the size for
> the total upload, and not individual files, it should call setFileSizeMax
> - HtmlFileUploadRenderer calls fileUpload.parseRequest(request), this will
> fail if any size exceptions are thrown, it would be better to use
> fileUpload.getItemIterator and catch each exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
