[ 
https://issues.apache.org/jira/browse/MYFACES-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752337#action_12752337
 ] 

Leonardo Uribe commented on MYFACES-2283:
-----------------------------------------

The patch looks good but we have a problem with the javascript. According to 
the jsf 2.0 spec renderkitdocs javadoc (page 
renderkitdocs/HTML_BASIC/renderkit-summary.html), on "General notes regarding 
the rendering of JavaScript in the standard components" says this:

"... Compliant implementations must only generate JavaScript in the  
javax.faces.Link and javax.faces.Button  Renderers for the javax.faces.Command 
component. The generation of JavaScript in any other Renderer in the HTML_BASIC 
renderkit is not permitted. However, any JavaScript code provided by the user 
as the value of a passthru attribute, such as "onmouseover", is excluded from 
this restriction....."

We can't commit the patch in this form, but we have to investigate if ri uses 
some javascript code in this place and how it does (maybe using client behavior 
api but at this point I'm speculating), before commit it.

> Apply selected/unselected css class to h:selectManyCheckbox
> -----------------------------------------------------------
>
>                 Key: MYFACES-2283
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2283
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>            Reporter: Leonardo Uribe
>         Attachments: selected-unselected.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to