[ 
https://issues.apache.org/jira/browse/MYFACES-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752929#action_12752929
 ] 

Leonardo Uribe commented on MYFACES-2345:
-----------------------------------------

Committed starting point of this feature. Added methods on FaceletFactory to 
deal with this type of facelet.

Assumptions:

- It is necessary to execute normally all tags inside f:metadata tag. This 
include converters, validators or other tags. It is not expected 
UIViewParameter to have child components but other authors could do something 
here, so the better is let this part open.
- f:metadata tag body should only be applied on create metadata time, not on 
build time. Otherwise, all children inside it could be corrupted. Maybe use 
ComponentHandler.isNew is enough but I'll feel better if we do something like 
FaceletViewDeclarationLanguage.getComponentMetadata(FacesContext, Resource): 
add a context param indicating that we are building metadata and then 
f:metadata check it and allow to apply next handler.
- Maybe better than create an alternate CompilationManager is create an 
alternate CompilationHandler (inside class SAXCompiler). This class is 
responsible for call CompilationManager on proper time and trigger unit 
creation.

> Add View Parameters feature
> ---------------------------
>
>                 Key: MYFACES-2345
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2345
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>
> See section 2.5.5 of the spec.
> Some parts where already done, but other code do not, so we have to review 
> and put in context all code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to