[ 
https://issues.apache.org/jira/browse/ORCHESTRA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leonardo Uribe updated ORCHESTRA-17:
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4
           Status: Resolved  (was: Patch Available)

> RequestParameterFacesContextFactory only works with HttpServletResponse
> -----------------------------------------------------------------------
>
>                 Key: ORCHESTRA-17
>                 URL: https://issues.apache.org/jira/browse/ORCHESTRA-17
>             Project: MyFaces Orchestra
>          Issue Type: Bug
>          Components: RequestParameterProvider
>    Affects Versions: 1.0, 1.1
>         Environment: Liferay Portlet Container
>            Reporter: Martin Marinschek
>            Assignee: Leonardo Uribe
>             Fix For: 1.4
>
>         Attachments: ORCHESTRA-17.patch
>
>
> The following snippet wrongly casts to HttpServletResponse, therefore 
> portlet-environments will not work:     
>    if (response instanceof HttpServletResponse)
>         {
>             HttpServletRequest httpServletRequest = (HttpServletRequest) 
> request;
>             
>             // Wrap this request only if something else (eg a 
> RequestParameterServletFilter) has not already wrapped it.
>             if 
> (!Boolean.TRUE.equals(httpServletRequest.getAttribute(RequestParameterServletFilter.REQUEST_PARAM_FILTER_CALLED)))
>             {
>        
> I will commit a solution very soon.
> regards,
> Martin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to