Hi Leonardo > On Tue, Oct 27, 2009 at 7:49 PM, Leonardo Uribe <[email protected]> wrote: Hi Leonardo,
>> >> Trying to solve MYFACES-2290 Add OSGi bundle information and bundle >> classloader / activator, it was submitted a patch that adds some new >> classes >> required by OSGi to handle classloader calls correctly. This classes >> requires be public and one be mentioned in myfaces-api MANIFEST.MF as >> Bundle-Activator. being rather ignorant on how OSGI internally works, I thought that any library can be OSGI compliant without needing any special code - it just needs to handle class-loading in an OSGI compliant way and provide OSGI meta-data. So I am wondering why this additional code is necessary - can you be more specific? >> Is it possible to add public classes under javax.faces package as in the >> patch (I don't think so but better to ask)? > > nope > >> Do this break TCK compatibility? > > I hope so I am sure it does ;) >> If the previous one is not possible, is it possible to add public classes >> under org.apache.myfaces like package in myfaces-api.jar, so we can >> correct >> the patch? Do this break TCK compatibility? > > hrm.... I am not sure if this breaks the TCK, but I am sure we don't > want public classes on our API JAR. Things can get dangerous > when 3rd party components start to depend on that one There should be nothing in the API which is public and not in the spec. But again, I don't see why this should be necessary. >> If the previous one is not possible, is it possible to create a single >> bundle of myfaces (mixing api and impl classes in one jar) or create >> separate jars with the modifications described before and put them on >> maven >> repo with a name like myfaces-api-osgi-X.X.X.jar or something like that to >> give users an alternative to use myfaces as a bundle in OSGi? > > having another "osgi" submodule that get's weaved into a bundle (API + > IMPL + OSGI) > and published as something like "myfaces-osgi-pack-x.y.z.jar" sounds > fine with me. Don't like this solution either - I am not hearing from other libraries having a "special" OSGI jar file. I am really wondering where that need comes from. regards, Martin -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
