Aloha,

convertNumber currently converts to Long when integerOnly="true"; I'd like to convert to BigInteger instead so that we're less likely to lose any precision.

There's a test in NumberConverterTestCase called testIntegerOnlyIsHonoured that expects Long values, so I changed it to expect BigInteger values instead, but I still got a test failure. Turns out this test case is used for both javax.faces.convert.NumberConverter and org.apache.myfaces.trinidad.convert.NumberConverter, so I only test against BigInteger values when the converter instance is the latter.

Please register any complaints with me.

Thanks,
Cale

Reply via email to