[
https://issues.apache.org/jira/browse/MYFACES-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829743#action_12829743
]
Matthias Weßendorf commented on MYFACES-2504:
---------------------------------------------
OK,
so the "final" patch is => "2504-3.diff" ?
Here are some comments.
* StartupServletContextListener:
+ getFacesInitializer(_servletContext).initFaces(_servletContext);
Doesn't that look odd ? Hrm..
* ContainerUtils:
=> .startsWith("Google App Engine"))
OK, but I wonder if they have some sort of guarantee for that ?
=> the isRunningOnGoogleAppEngine() has some duplicated code...
Also regarding getServerInfo() I filed this:
https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=739
Doc patch is OK. what is the license for the "jdo2-api-2.3-eb.jar" JAR?
Datanuculus is Apache.
(cool plugin btw)
A demo app would be cool :-)
> Google App Engine Support
> -------------------------
>
> Key: MYFACES-2504
> URL: https://issues.apache.org/jira/browse/MYFACES-2504
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-252, JSR-314
> Affects Versions: 1.2.8, 2.0.0-alpha
> Environment: Google App Engine 1.3
> Reporter: Ali Ok
> Priority: Minor
> Attachments: 2504-2.diff, 2504-3.diff, 2504-doc.diff, 2504.diff
>
>
> Support for Google App Engine for MyFaces 1.2 and 2.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
