[
https://issues.apache.org/jira/browse/MYFACES-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe resolved MYFACES-2538.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-beta-2
Solved as rev A change log says, so libraryVersion and resourceVersion now it
is optional on resources under META-INF/resources/. Since ri implements this
behavior too, we are safe.
> Remove resourceVersion and libraryVersion from resource identifiers
> -------------------------------------------------------------------
>
> Key: MYFACES-2538
> URL: https://issues.apache.org/jira/browse/MYFACES-2538
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Priority: Critical
> Fix For: 2.0.0-beta-2
>
>
> Martin Koci From dev list:
> "...during profiling YourKitProfiler always marks
> org.apache.myfaces.resource.ClassLoaderResourceLoader.getLibraryVersion(String)
> as hotspot - that method always takes 30--50% CPU time per one
> request/response. Is it a known problem? I will provide more information
> later...."
> Answer from Leonardo:
> "....Yes, that one is a big problem. There is no way to "traverse" a jar file
> without iterating over all entries to get the library version and resource
> version. That means the current algorithm do that all times a resource is
> rendered. This is really bad.
> I remember someone commented that on jsr-314-open at jcp.org mailing list,
> and checking the latest ri code (2.0.2-b10), library and resource version
> feature was removed. It seems a decision was taken there.
> Checking more, the topic describing this is:
> [jsr-314-open] Need guidance: invalid assumptions in design of resource
> versioning feature
> We should change our algorithm too to prevent this performance problem....."
> This one is critical to be solved before release beta 2, because it cause a
> really seriour performance problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
