[
https://issues.apache.org/jira/browse/MYFACES-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831477#action_12831477
]
Jakob Korherr commented on MYFACES-2542:
----------------------------------------
Thanks for pointing that out and for the patch.
However, there are many problems with the patch: First the changed class is
duplicated in javax.faces.component package (look at the comment at the top of
the class), so this class has to be changed too. Second the patch contains
unnecessary imports. Furthermore you should use FacesContext.isProjectStage()
to check the current project stage (that's just more beautiful). Also you
forgot to add {2} in the log message to print out the type of the value. And
last but not least please take a look at your code format. There are not very
strict rules for splitting parameter lists in two or more lines - it's mostly
up to you, but it should be easily readable!
> Don't throw exception if no SelectItems found
> ----------------------------------------------
>
> Key: MYFACES-2542
> URL: https://issues.apache.org/jira/browse/MYFACES-2542
> Project: MyFaces Core
> Issue Type: New Feature
> Components: General
> Affects Versions: 2.0.0-beta-2
> Environment: myfaces trunk
> Reporter: Martin Koci
> Priority: Trivial
> Attachments: MYFACES-2542.patch
>
>
> if <f:selectItems value="#{aNonExistentModel}" /> resolves in runtime to
> null a expection is throw. But having no SelectItem(s) is legal and this
> state should not breaks view processing/rendering. JSF RI handles this
> situation without a exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
