[
https://issues.apache.org/jira/browse/TRINIDAD-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeanne Waldman resolved TRINIDAD-1714.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.14-core
> Mark the skin as dirty if DesignTime mode and
> org.apache.myfaces.trinidad.skin.id is set.
> -----------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1714
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1714
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Reporter: Jeanne Waldman
> Assignee: Jeanne Waldman
> Fix For: 1.2.14-core
>
> Attachments: 1714patchfor12122.patch
>
>
> Our Design Time team wasn't satisfied with "TRINIDAD-1637 always check for
> file modification if in DesignTime mode regardless of web.xml setting".
> Instead, they'd rather if we always update the skin. Since we now have the
> skin.isDirty/setDirty apis, we can use those.
> The fix for this is in StyleContextImpl. Revert the change for 1637 and in
> StyleContextImpls's isDirty, return true if DesignTime mode && flag is set.
> Also, in this case, setDirty to true on the skin in case someone is checking
> the skin instead of the StyleContext.
> Also, in FileSystemStyleCache, instead of calling skin.isDirty, call
> styleContext.isDirty like I should have done in the first place.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
