[
https://issues.apache.org/jira/browse/MYFACES-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832238#action_12832238
]
Leonardo Uribe commented on MYFACES-2544:
-----------------------------------------
The latest patch (MYFACES-2544-4.patch) uses encodeBegin() and encodeEnd(), but
before execute encodeChildren() or encodeEnd() it check for
getResponseComplete(). If no objections, I'll commit this code soon.
> UIViewRoot skips uncorrectly encodeBegin
> ----------------------------------------
>
> Key: MYFACES-2544
> URL: https://issues.apache.org/jira/browse/MYFACES-2544
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Environment: myfaces trunk
> Reporter: Martin Koci
> Assignee: Jakob Korherr
> Fix For: 2.0.0-beta-2
>
> Attachments: MYFACES-2544-2.patch, MYFACES-2544-3.patch,
> MYFACES-2544-4.patch, MYFACES-2544.patch
>
>
> javax.faces.component.UIViewRoot.encodeBegin(FacesContext) contains:
> if (!skipPhase) {
> super.encodeBegin(context);
> }
> but skipPhase = context.getRenderResponse() || context.getResponseComplete()
> - it
> makes sense for all phases except render response phase itself. That condition
> probably should be:
> if (!context.getResponseComplete()) {
> super.encodeBegin(context);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
