Hi Mark and Matthias,

I am also currently investigating the problem here, but this was far before
my time (somewhere in MyFaces 1.2). However I think we should do what the
JavaDoc says (set the current DataModel) and apply this change not only on
the trunk, but also on the JSF 1.2 branch, because the JSF 1.2 JavaDoc says
exactly the same (I just checked that).

It is really interesting why it does not do what the method name would tell
you to expect. I don't believe it had to do with the TCK. Maybe it was just
forgotten to implement on MyFaces 1.2 and not tested by the "old" TCK.

However it would be great to get some further information about that. Thanks
in advance for that, Matthias!

Regards,
Jakob

2010/2/25 Matthias Wessendorf <[email protected]>

> HEy Mark,
>
> interesting found!
>
> On Thu, Feb 25, 2010 at 6:25 PM, Mark Struberg <[email protected]> wrote:
> > I found the following source in UIData of the latest from trunk (2.0.0):
> >
> >    protected void setDataModel(DataModel dataModel)
> >    {
> >        throw new UnsupportedOperationException("this method is here only
> to maintain binary compatibility w/ the RI");
> >    }
> >
> > which make a few libraries crash.
> >
> > Is there any reason for that change?
> > Or better: is this defined in the JSF-2 spec?
>
> Nope, I'd say. This has been done almost 4 years ago:
> http://bit.ly/bXtzWq
>
> I took a look at the "official" JavaDoc and they actually say
> something meaningful...
>
> http://java.sun.com/javaee/javaserverfaces/2.0/docs/api/javax/faces/component/UIData.html#setDataModel(javax.faces.model.DataModel)<http://java.sun.com/javaee/javaserverfaces/2.0/docs/api/javax/faces/component/UIData.html#setDataModel%28javax.faces.model.DataModel%29>
>
> >
> > What is the reason for that change?
>
> <log-message>
> added 23 methods for binary compatibility w/ the RI
> 12 methods throw UnsupportedOperationException in this commit
> added 1.5 features to FactoryFinder
> added new class called HtmlColumn
> </log-message>
>
> I can track down 2morrow if there was some *old* tck issue or similar
>
> -Matthias
>
> >
> > I worked around by using DataModel#setWrappedData(Object) instead, but
> not sure about the side effects...
> >
> > txs and LieGrue,
> > strub
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz
> gegen Massenmails.
> > http://mail.yahoo.com
> >
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>

Reply via email to