[
https://issues.apache.org/jira/browse/TRINIDAD-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Max Starets updated TRINIDAD-1735:
----------------------------------
Status: Patch Available (was: Open)
> Trinidad 2: Provide ViewDeclarationLanguageFactory wrapper instead of
> overriding ViewHandler.getViewDeclarationLanguage()
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1735
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1735
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 2.0.0.2-core
> Reporter: Max Starets
> Assignee: Max Starets
> Attachments: trinidad-1735.diff
>
>
> We override ViewHandler.getViewDeclarationLanguage() to return null VDL for
> the internal views and to call inro PageResolver before determining the VDL.
> The problem is our override does not get called during
> ViewHandler.createView() because the delegate ViewHandler just calls
> getViewDeclarationLanguage on itself. This is not causing any serious
> problems today because both Facelets and JSP VDLs call into the same base
> implementation of createView(). However, the right solution will be to stop
> overriding getViewDeclarationLanguage() on the ViewHandler and start wrapping
> ViewDeclarationLanguageFactory instead, so we can start overriding
> getViewDeclarationLanguage() there.
> According to JavaDoc, ViewHandler.getViewDeclarationLanguage() is merely a
> convenience method. As such it should have been made final in the JSF API,
> and problems like these would be easily prevented.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
