[ 
https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848656#action_12848656
 ] 

Martin Marinschek commented on MYFACES-2618:
--------------------------------------------

Hi Jakob,

I am not sure, I think I might object ;)

Why that warning is invented is easily explained: users often forget that the 
rendered attribute needs to be bound to a bean in scope session or conversation.

And if they forget this, the rendered attribute might have toggled (to true), 
and suddenly we try to decode something for which no submitted value is there. 
To give the user at least some information that there is a problem, we log that 
warning.

Now, for the AJAX case: if nothing is submitted, why would you run the decoding 
for this field? That sounds a bit strange to me. You might decide to execute 
only some of the fields, but then you would also submit these fields - a split 
between submitting some and decoding some others is nothing which I would see 
as being useful.

In short: I need more information to decide that I would object, but I think I 
will.

best regards,

Martin

> Don't warn if there is no submitted value in the current request for every 
> EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for 
> paramMap.containsKey(clientId) and if this returns false (meaning that there 
> is no submitted value for the given component in the request parameter map) 
> we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is 
> on my opinion normal to not submit all values of a form in every request. 
> Furthermore it has no impact on the lifecycle, because if the submitted value 
> is null it just isn't processed any further.
> See also the related thread on the mailing list: 
> http://www.mail-archive.com/[email protected]/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to