On my machine it all works fine. I'm using Mac OS X 10.6.3, Java 1.6.0_17 and Maven 2.2.1.
Just a guess in the blue - The changes I applied are on shared. Did you guys remember to rebuild shared before running the test on impl? Regards, Jakob 2010/4/15 Werner Punz <[email protected]> > Could also be a simple encoding issue which is more likely on a second > thought (and as Jan has pointed out), the replaceAll is highly unlikely to > be inconsistent in its weird behavior, never encountered that. > Anyway as I said I will have a look as soon as it is possible for me > (otherwise someone else can quickly check what the cause of the problem is) > > Werner > > > Am 15.04.10 10:06, schrieb Werner Punz: > > Ok the affected part is the escape quoting, which had a bug recently >> which Jakob fixed. >> >> inputText.getAttributes().put("onchange", "alert('test')"); >> >> The test checks for following: >> >> assertTrue(output.contains("'alert(\\'test\\')'")); >> >> but the output string I am getting here is: >> <input id="j_id0" name="j_id0" type="text" value="" >> onchange="jsf.util.chain(document.getElementById('j_id0'), >> event,'alert('test')');"/> >> >> 'alert('test')' here should be an escaping hence >> the test fails rightfully, what however strikes me is why it fails on >> some systems and on some it does not, I assume it has to do with the >> strange replaceAll behavior java has (which does additional escaping to >> the normal one in the replacement part, this might be inconsistent over >> various platforms (usually you fall into this trap if you do file >> separator operations and then move over to windows)). >> >> But this is just a wild guessing, if no one else is able to fix it I >> will have a look in the afternoon, but for now I have to serve a customer. >> >> Werner >> >> >> >> >> Am 15.04.10 09:30, schrieb Werner Punz: >> >>> Ok here is some additional information: >>> >>> <testsuite failures="2" time="0.037" errors="0" skipped="0" tests="6" >>> name="org.apache.myfaces.renderkit.html.HtmlTextRendererTest"> >>> <properties> >>> <property name="java.runtime.name" value="Java(TM) SE Runtime >>> Environment"/> >>> <property name="sun.boot.library.path" >>> >>> value="/System/Library/Frameworks/JavaVM.framework/Versions/1.6.0/Libraries"/> >>> >>> >>> <property name="java.vm.version" value="14.3-b01-101"/> >>> .... >>> >>> >>> >>> <testcase time="0.006" >>> name="testClientBehaviorUserCodeJavaScriptEscaping"> >>> <failure >>> >>> type="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError >>> >>> >>> at >>> >>> org.apache.myfaces.renderkit.html.HtmlTextRendererTest.testClientBehaviorUserCodeJavaScriptEscaping(HtmlTextRendererTest.java:215) >>> >>> >>> </failure> >>> </testcase> >>> <testcase time="0.005" >>> name="testClientBehaviorUserCodeJavaScriptDoubleEscaping"> >>> <failure >>> >>> type="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError >>> >>> >>> at >>> >>> org.apache.myfaces.renderkit.html.HtmlTextRendererTest.testClientBehaviorUserCodeJavaScriptDoubleEscaping(HtmlTextRendererTest.java:237) >>> >>> >>> </failure> >>> >>> >>> >>> >>> Am 15.04.10 09:22, schrieb Jan-Kees van Andel: >>> >>>> I just runned the build on Windows Vista x64: >>>> >>>> D:\dev\work\myfaces2\core_2_0_0>mvn --version >>>> Maven version: 2.0.10 >>>> Java version: 1.6.0_14 >>>> OS name: "windows vista" version: "6.0" arch: "amd64" Family: "windows" >>>> >>>> The tests worked fine. >>>> >>>> @Matthias: Can you see which test method is causing the issue and which >>>> assertion fails (or which exception is thrown)? >>>> >>>> /JK >>>> >>>> >>>> >>>> >>>> 2010/4/15 Matthias Wessendorf <[email protected] >>>> <mailto:[email protected]>> >>>> >>>> that's funny :-) >>>> >>>> What JDK ? 1.5 ? >>>> >>>> I am on 1.6.x >>>> => >>>> mat...@woody:~/work/source/Apache/myfaces/trunk$ mvn -v >>>> Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200) >>>> Java version: 1.6.0_13 >>>> Java home: /java/jdk1.6.0_13/jre >>>> Default locale: en_US, platform encoding: UTF-8 >>>> OS name: "linux" version: "2.6.31-19-generic" arch: "i386" Family: >>>> "unix" >>>> >>>> >>>> >>>> On Thu, Apr 15, 2010 at 8:55 AM, Leonardo Uribe <[email protected] >>>> <mailto:[email protected]>> wrote: >>>> > Hi >>>> > >>>> > In my machine works fine. I compiled sources on both Linux and >>>> Windows. >>>> > >>>> > regards, >>>> > >>>> > Leonardo Uribe >>>> > >>>> > 2010/4/15 Matthias Wessendorf <[email protected] >>>> <mailto:[email protected]>> >>>> >> >>>> >> These two revisions cause the problem: >>>> >> >>>> >> http://svn.apache.org/viewvc?view=revision&revision=933814 >>>> <http://svn.apache.org/viewvc?view=revision&revision=933814> >>>> >> http://svn.apache.org/viewvc?view=revision&revision=933812 >>>> <http://svn.apache.org/viewvc?view=revision&revision=933812> >>>> >> >>>> >> On Thu, Apr 15, 2010 at 7:43 AM, Matthias Wessendorf >>>> <[email protected] <mailto:[email protected]>> >>>> >> wrote: >>>> >> > Yesterday I mentioned the same, on trunk >>>> >> > >>>> >> > I am on Linux, Werner is on OS X. >>>> >> > Jakob/Leo: r u windoze ? >>>> >> > >>>> >> > Thx, >>>> >> > Matthias >>>> >> > >>>> >> > PS: I changed the subject to not hijack the vote ;-) >>>> >> > >>>> >> > On Thu, Apr 15, 2010 at 7:37 AM, Werner Punz >>>> <[email protected] <mailto:[email protected]>> >>>> >> > wrote: >>>> >> >> Before I am giving my vote here, there is still a unit test >>>> failure ... >>>> >> >> >>>> >> >> >>>> >> >> Am 15.04.10 06:39, schrieb Matthias Wessendorf: >>>> >> >>> >>>> >> >>> +1 >>>> >> >>> >>>> >> >>> Thanks for running this >>>> >> >>> >>>> >> >>> Sent from my iPod. >>>> >> >>> >>>> >> >>> On 15.04.2010, at 03:48, Leonardo Uribe <[email protected] >>>> <mailto:[email protected]> >>>> >> >>> <mailto:[email protected] <mailto:[email protected]>>> wrote: >>>> >> >>> >>>> >> >>>> +1 >>>> >> >>>> >>>> >> >>>> 2010/4/14 Leonardo Uribe < <mailto:[email protected] >>>> <mailto:[email protected]>>[email protected] <mailto:[email protected]> >>>> >> >>>> <mailto:[email protected] <mailto:[email protected]>>> >>>> >> >>>> >>>> >> >>>> Hi, >>>> >> >>>> >>>> >> >>>> I was running the needed tasks to get the 2.0.0 release >>>> of Apache >>>> >> >>>> MyFaces core out. >>>> >> >>>> >>>> >> >>>> Minor fixes were done since the latest proposed artifacts >>>> >> >>>> (MYFACES-2658, MYFACES-2659 and MYFACES-2660), so we can >>>> >> >>>> continue with the vote. >>>> >> >>>> >>>> >> >>>> The artifacts passed all TCK tests. >>>> >> >>>> >>>> >> >>>> Please note that this vote concerns all of the following >>>> parts: >>>> >> >>>> 1. Maven artifact group "org.apache.myfaces.shared" >>>> v4.0.1 [1] >>>> >> >>>> 2. Maven artifact group "org.apache.myfaces.core" v2.0.0 [1] >>>> >> >>>> 3. Maven artifact group "org.apache.myfaces.test" >>>> v1.0.0-beta-3 >>>> >> >>>> [1] >>>> >> >>>> >>>> >> >>>> The artifacts are deployed to my private Apache account >>>> ([1] and >>>> >> >>>> [3] for binary and source packages). >>>> >> >>>> >>>> >> >>>> The release notes could be found at [4]. >>>> >> >>>> >>>> >> >>>> Also the clirr test does not show binary >>>> incompatibilities with >>>> >> >>>> myfaces-api. >>>> >> >>>> >>>> >> >>>> Please take a look at the "2.0.0" artifacts and vote! >>>> >> >>>> >>>> >> >>>> Please note: This vote is "majority approval" with a >>>> minimum of >>>> >> >>>> three >>>> >> >>>> +1 votes (see [3]). >>>> >> >>>> >>>> >> >>>> ------------------------------------------------ >>>> >> >>>> [ ] +1 for community members who have reviewed the bits >>>> >> >>>> [ ] +0 >>>> >> >>>> [ ] -1 for fatal flaws that should cause these bits not >>>> to be >>>> >> >>>> released, >>>> >> >>>> and why.............. >>>> >> >>>> ------------------------------------------------ >>>> >> >>>> >>>> >> >>>> Thanks, >>>> >> >>>> Leonardo Uribe >>>> >> >>>> >>>> >> >>>> [1] >>>> >> >>>> >>>> >> >>>> >>>> >> >>>> >>>> <http://people.apache.org/%7Elu4242/myfaces200> >>>> http://people.apache.org/~lu4242/myfaces200<http://people.apache.org/%7Elu4242/myfaces200> >>>> >>>> >>>> <http://people.apache.org/%7Elu4242/myfaces200> >>>> >> >>>> [2] >>>> >> >>>> >>>> >> >>>> >>>> >> >>>> >>>> <http://www.apache.org/foundation/voting.html#ReleaseVotes> >>>> http://www.apache.org/foundation/voting.html#ReleaseVotes >>>> >>>> >>>> >> >>>> [3] >>>> >> >>>> >>>> >> >>>> >>>> >> >>>> >>>> <http://people.apache.org/%7Elu4242/myfaces200binsrc> >>>> http://people.apache.org/~lu4242/myfaces200binsrc<http://people.apache.org/%7Elu4242/myfaces200binsrc> >>>> >>>> >>>> <http://people.apache.org/%7Elu4242/myfaces200binsrc> >>>> >> >>>> [4] >>>> >> >>>> >>>> >> >>>> >>>> >> >>>> >>>> < >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890 >>>> >>>> >>>> < >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890 >>>> >> >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890 >>>> >>>> >>>> < >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890 >>>> > >>>> >>>> >>>> >> >>>> >>>> >> >>>> >>>> >> >>>> >>>> < >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890 >>>> >>>> >>>> < >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890 >>>> >> >>>> >>>> >>>> >> >>>> >>>> >> >>>> >>>> >> >> >>>> >> >> >>>> >> >> >>>> >> > >>>> >> > >>>> >> > >>>> >> > -- >>>> >> > Matthias Wessendorf >>>> >> > >>>> >> > blog: http://matthiaswessendorf.wordpress.com/ >>>> >> > sessions: http://www.slideshare.net/mwessendorf >>>> >> > twitter: http://twitter.com/mwessendorf >>>> >> > >>>> >> >>>> >> >>>> >> >>>> >> -- >>>> >> Matthias Wessendorf >>>> >> >>>> >> blog: http://matthiaswessendorf.wordpress.com/ >>>> >> sessions: http://www.slideshare.net/mwessendorf >>>> >> twitter: http://twitter.com/mwessendorf >>>> > >>>> > >>>> >>>> >>>> >>>> -- >>>> Matthias Wessendorf >>>> >>>> blog: http://matthiaswessendorf.wordpress.com/ >>>> sessions: http://www.slideshare.net/mwessendorf >>>> twitter: http://twitter.com/mwessendorf >>>> >>>> >>>> >>> >>> >>> >> >> >> > > -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
