Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

Ganesh Thu, 15 Apr 2010 03:10:32 -0700

Would be cool to have a working build for the release, otherwise it's hard to 
decide whether it works :-)


Werner Punz schrieb:

Not yet, the reason is I am not sure which shared version we shouldreference for the impl on the trunk (either 4.0.1 or 4.0.2-SNAPSHOT orwe revert our shared version again back to 4.0.1-SNAPSHOT), since Leo isthe release manager he has to decide, I guess.
Werner


Am 15.04.10 11:43, schrieb Ganesh:
Hi,

I've updated current20 to rev 934345 and restarted a mvn build, but it
still fails (same errors as before). Having already checked in your
findings?

Best regards,
Ganesh

Werner Punz schrieb:
Actually I had a quick look at the branch for 2.0.0 this one has the
version set correctly to 4.0.1, but you cannot really build it from
scratch because it refers to test 2.0-beta-3 final and shared 4.0.1
which of course maven cannot fetch yet.

Sorry for being so nitpicky, but I have the opinion that a user who
checks out the code should be able to compile everything with a single
mvn clean install.

Werner



Am 15.04.10 11:22, schrieb Jakob Korherr:
Many thanks werner for pointing this out!

I was sure that the code and the tests I committed were right, so I'm
happy we now found the real problem!

Regards,
Jakob

2010/4/15, Werner Punz<[email protected]>:
Ok I think I nailed it down, if you checkout current 2.0 you get
both, but the test fails, the reason is:

MyFaces 2.0 Impl refers to Shared 4.0.1-SNAPSHOT
while we already have 4.0.2-SNAPSHOT in the trunk.
Now if the 4.0.1-SNAPSHOT is present in the local repo but
does not have the fix in the testcase fails.

So we have a version conflict in our build here the build versions on
the trunk are incorrect.
That is also the reason why it fails for some and works for others, no
encoding problem simply a broken version in the build files.

I upped the version in the impl to 4.0.2-SNAPSHOT and it works fine
here
the test failures are gone.

Werner



Am 15.04.10 10:33, schrieb Jakob Korherr:
You need to check out shared 4.0.1 in addition to core and run the
build
on both. The best here is to check out current20. Otherwise you will
have old versions of shared which will cause "problems" like yours.

Regards,
Jakob

2010/4/15 Jan-Kees van Andel<[email protected]
<mailto:[email protected]>>

I encountered the same error on trunk. You need to change the
shared-impl version property to 4.0.1 and then it should work.

Regards,
Jan-Kees


2010/4/15 Ganesh<[email protected]<mailto:[email protected]>>

Sorry for the inconvenience, for me impl build fails on
myfaces/current20 (last tried 10 days ago, worked then). It's
propably an oversight on my side, but I would have liked to a
quick retest with dojofaces for 2.0.0 ... any ideas?

[INFO] Compiling 74 source files to
C:\projects\MyFaces_current20\core\impl\target\classes
[INFO]
------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Compilation failure
C:\projects\MyFaces_current20\core\impl\src\main\java\org\apache\myfaces\context\servlet\ServletExternalContextImpl.java:[56,51]
package org.apache.myfaces.shared_impl.context.flash does not
exist
C:\projects\MyFaces_current20\core\impl\src\main\java\org\apache\myfaces\context\ExceptionHandlerFactoryImpl.java:[24,45]
cannot find symbol
symbol : class ExceptionHandlerImpl
location: package org.apache.myfaces.shared_impl.context
C:\projects\MyFaces_current20\core\impl\src\main\java\org\apache\myfaces\view\facelets\compiler\TagLibraryConfig.java:[616,65]
cannot find symbol
symbol : method isValidateXML()
location: class
org.apache.myfaces.shared_impl.config.MyfacesConfig
C:\projects\MyFaces_current20\core\impl\src\main\java\org\apache\myfaces\view\facelets\compiler\TagLibraryConfig.java:[684,61]
cannot find symbol
symbol : method isValidateXML()
location: class
org.apache.myfaces.shared_impl.config.MyfacesConfig
C:\projects\MyFaces_current20\core\impl\src\main\java\org\apache\myfaces\context\servlet\ServletExternalContextImpl.java:[921,15]
cannot find symbol
symbol : variable FlashImpl
location: class
org.apache.myfaces.context.servlet.ServletExternalContextImpl
C:\projects\MyFaces_current20\core\impl\src\main\java\org\apache\myfaces\config\FacesConfigurator.java:[543,62]
cannot find symbol
symbol : method isValidateXML()
location: class
org.apache.myfaces.shared_impl.config.MyfacesConfig
C:\projects\MyFaces_current20\core\impl\src\main\java\org\apache\myfaces\config\FacesConfigurator.java:[772,70]
cannot find symbol
symbol : method isValidateXML()
location: class
org.apache.myfaces.shared_impl.config.MyfacesConfig
C:\projects\MyFaces_current20\core\impl\src\main\java\org\apache\myfaces\config\FacesConfigurator.java:[806,66]
cannot find symbol
symbol : method isValidateXML()
location: class
org.apache.myfaces.shared_impl.config.MyfacesConfig
C:\projects\MyFaces_current20\core\impl\src\main\java\org\apache\myfaces\config\FacesConfigurator.java:[864,62]
cannot find symbol
symbol : method isValidateXML()
location: class
org.apache.myfaces.shared_impl.config.MyfacesConfig
C:\projects\MyFaces_current20\core\impl\src\main\java\org\apache\myfaces\view\facelets\compiler\EndElementInstruction.java:[47,33]
cannot find symbol
symbol : method
renderUnhandledFacesMessages(javax.faces.context.FacesContext)
location: class
org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils


[INFO]
------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 1 minute 12 seconds
[INFO] Finished at: Thu Apr 15 10:14:54 CEST 2010
[INFO] Final Memory: 105M/452M
[INFO]
------------------------------------------------------------------------
Best regards,
Ganesh

Werner Punz schrieb:

Before I am giving my vote here, there is still a unit test
failure ...


Am 15.04.10 06:39, schrieb Matthias Wessendorf:

+1

Thanks for running this

Sent from my iPod.

On 15.04.2010, at 03:48, Leonardo Uribe
<[email protected]<mailto:[email protected]>
<mailto:[email protected]<mailto:[email protected]>>>
wrote:

+1

2010/4/14 Leonardo Uribe< <mailto:[email protected]
<mailto:[email protected]>>[email protected]
<mailto:[email protected]>
<mailto:[email protected]<mailto:[email protected]>>>

Hi,

I was running the needed tasks to get the 2.0.0
release of Apache
MyFaces core out.

Minor fixes were done since the latest proposed
artifacts
(MYFACES-2658, MYFACES-2659 and MYFACES-2660),
so we can
continue with the vote.

The artifacts passed all TCK tests.

Please note that this vote concerns all of the
following parts:
1. Maven artifact group
"org.apache.myfaces.shared" v4.0.1 [1]
2. Maven artifact group
"org.apache.myfaces.core" v2.0.0 [1]
3. Maven artifact group
"org.apache.myfaces.test" v1.0.0-beta-3 [1]

The artifacts are deployed to my private Apache
account ([1] and
[3] for binary and source packages).

The release notes could be found at [4].

Also the clirr test does not show binary
incompatibilities with
myfaces-api.

Please take a look at the "2.0.0" artifacts and
vote!

Please note: This vote is "majority approval"
with a minimum of three
+1 votes (see [3]).

------------------------------------------------
[ ] +1 for community members who have reviewed
the bits
[ ] +0
[ ] -1 for fatal flaws that should cause these
bits not to be
released,
and why..............
------------------------------------------------

Thanks,
Leonardo Uribe

[1]
<http://people.apache.org/%7Elu4242/myfaces200>http://people.apache.org/~lu4242/myfaces200
<http://people.apache.org/%7Elu4242/myfaces200>
[2]
<http://www.apache.org/foundation/voting.html#ReleaseVotes>http://www.apache.org/foundation/voting.html#ReleaseVotes
[3]
<http://people.apache.org/%7Elu4242/myfaces200binsrc>http://people.apache.org/~lu4242/myfaces200binsrc
<http://people.apache.org/%7Elu4242/myfaces200binsrc>
[4]
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890>>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890>
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12314890>>
--
"There are two kinds of people in the world, those who believe
there are two kinds of people and those who don't."
— Robert Benchley





--
Jakob Korherr

blog: http://www.jakobk.com
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at


--
"There are two kinds of people in the world, those who believe there are two kinds 
of people and those who don't."
— Robert Benchley

Re: impl build fails - Re: [VOTE] release for myfaces core 2.0.0

Reply via email to