[
https://issues.apache.org/jira/browse/TRINIDAD-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859565#action_12859565
]
Jeanne Waldman commented on TRINIDAD-1782:
------------------------------------------
I plan to do:
1. change _styleNodeToStyleMap from being a class variable to a method variable.
2. cache the calculated has code to avoid expensive computation.
> Live mmeory from style sheet cache
> ----------------------------------
>
> Key: TRINIDAD-1782
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1782
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 1.2.12-core
> Reporter: Stevan Malesevic
> Fix For: 2.0.0.3-core
>
>
> Trinidad 1702 optimized a memory for style cache by introducing cache map.
> There are a couple of issues with this fix and couple of optimizations that
> should be done to reduce memory and cpu
> 1. _styleNodeToStyleMap maps key to cssstlye. What happens is that StyleKey
> holds onto style properties and then CSSStyle copies style properties. So we
> end up with both StyleKey and CSSStlye pinning memory for the same thing.
> This essentially doubles a memory usage. IN some test apps memory per browser
> was 7.2MB and then multipley bu number of browsers. This memory should be
> just 3.6MB per browser if we avoid copy of the map in BaseStlye but rather
> referece styles
> 2. StyleKey should cache calculated hash code to avoid expensive computation
> 3. _styleNodeToStyleMap might be moved to FileSystemStyleCache to take
> adventage of same entires on the higher , browser or verion or platform layer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
