Hi Leo, Yes I just realized that, because my IDE told me that there are compilation errors on myfaces-impl. So I was a bit to fast in just reverting your commit, sorry!
However we have to find a solution that does not include the sources in the IDE, but in the sources.jar. When I first implemented the merging of implee6 and impl I moved the addition of the implee6-sources to a later phase in maven to circumvent this problem, but I think this causes problems in the release. Do you remember exactly why this was wrong? Regards, Jakob 2010/4/26 Leonardo Uribe <[email protected]> > Hi Jakob > > The problem with let implee6 is that when I execute the goal mvn > eclipse:eclipse, it is included on the source path, but since the files on > ee6 are compiled by a different environment, it shows like there is an > error. > > regards, > > Leonardo Uribe > > 2010/4/26 Jakob Korherr <[email protected]> > > Hi Leonardo, >> >> Actually it is necessary to add the sources, otherwise >> myfaces-impl-2.0.1-SNAPSHOT-sources.jar would not contain the source files >> from implee6, which it definitely has to! >> >> Thus I will revert this commit. >> >> Regards, >> Jakob >> >> 2010/4/23 <[email protected]> >> >>> Author: lu4242 >>> Date: Fri Apr 23 18:15:50 2010 >>> New Revision: 937451 >>> >>> URL: http://svn.apache.org/viewvc?rev=937451&view=rev >>> Log: >>> add as source dir implee6 is not necessary (added .java as resource >>> instead) >>> >>> Modified: >>> myfaces/core/trunk/impl/pom.xml >>> >>> Modified: myfaces/core/trunk/impl/pom.xml >>> URL: >>> http://svn.apache.org/viewvc/myfaces/core/trunk/impl/pom.xml?rev=937451&r1=937450&r2=937451&view=diff >>> >>> ============================================================================== >>> --- myfaces/core/trunk/impl/pom.xml (original) >>> +++ myfaces/core/trunk/impl/pom.xml Fri Apr 23 18:15:50 2010 >>> @@ -506,7 +506,9 @@ >>> <configuration> >>> <sources> >>> >>> <source>${project.build.directory}/shared_sources</source> >>> + <!-- >>> >>> <source>${project.build.directory}/implee6_sources</source> >>> + --> >>> </sources> >>> </configuration> >>> </execution> >>> >>> >>> >> >> >> -- >> Jakob Korherr >> >> blog: http://www.jakobk.com >> twitter: http://twitter.com/jakobkorherr >> work: http://www.irian.at >> > > -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
