[
https://issues.apache.org/jira/browse/MYFACES-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe updated MYFACES-2759:
------------------------------------
Status: Resolved (was: Patch Available)
Fix Version/s: 2.0.1-SNAPSHOT
(was: 2.0.2-SNAPSHOT)
Resolution: Fixed
I seems I committed a similar patch the same day you proposed a patch. I think
it is better to do the cast to prevent a ClassCastException, but in theory as
you said it is not necessary because defaultExternalContext implements
ReleasableExternalContext. In theory, we should cast first the returned
ExternalContext interface and then the default one.
> Clean up FacesContextImpl
> -------------------------
>
> Key: MYFACES-2759
> URL: https://issues.apache.org/jira/browse/MYFACES-2759
> Project: MyFaces Core
> Issue Type: Task
> Components: JSR-314
> Affects Versions: 2.0.0
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Priority: Minor
> Fix For: 2.0.1-SNAPSHOT
>
> Attachments: MYFACES-2759.patch
>
>
> There are currently some unnecessary init methods and contructor attributes
> (ReleaseableExternalContext) on FacesContextImpl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
