[
https://issues.apache.org/jira/browse/MYFACES-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889084#action_12889084
]
Jakob Korherr commented on MYFACES-2824:
----------------------------------------
I have a question regarding your patch:
Why do you return true in visitTree()? Returning true makes the tree visit to
stop completely and not just for this component, see UIComponent.visitTree():
if (getChildCount() > 0) {
for (UIComponent child : getChildren()) {
if (child.visitTree(context, callback)) {
return true;
}
}
}
I think visitTree() should return false in this case, or is there something I
am missing?
> Improve invokeOnComponent and visitTree methods in UILeaf
> ---------------------------------------------------------
>
> Key: MYFACES-2824
> URL: https://issues.apache.org/jira/browse/MYFACES-2824
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 2.0.0
> Reporter: Marius Petoi
> Priority: Minor
> Attachments: uiLeafImprovements.patch
>
>
> UILeaf components are stateless. They have no children and no facets.
> Therefore, the invokeOnComponent and visitTree methods should not go through
> all the children and facets. Moreover, they do not have any callback
> invocations through these methods or through a system event. The
> invokeOnComponent and visitTree methods should be overridden accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
