[
https://issues.apache.org/jira/browse/MYFACES-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890402#action_12890402
]
Michael Concini commented on MYFACES-2830:
------------------------------------------
Quick question on the change to skip validation if the valueExpression is null.
Wouldn't it be better to update the method signature for the private method
BeanValidator.getValueReference() and pass the ValueExpression if we're going
to obtain it anyway in validate() for the null check? Might be nitpicking, but
that would prevent having to make multiple calls to
component.getValueExpression("value").
Just a thought...since its an internal private method we don't have to worry
about breaking compatibility. Plus we don't use the UIComponent object
anywhere else other than to get the ValueExpression and pass it to
_BeanValidatorUELUtils.getUELValueReferenceWrapper().
> ourEL wrappers doesn't honour the new EL-2.2 'invoke' method
> ------------------------------------------------------------
>
> Key: MYFACES-2830
> URL: https://issues.apache.org/jira/browse/MYFACES-2830
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Mark Struberg
>
> EL-2.2 defines a new method
> Object invoke(ELContext context, Object base, Object method, Class<?>[]
> paramTypes, Object[] params)
> for ELResolvers which by default returns null;
> This doesn't get honoured in our EL Wrappers like e.g.
> BeanValidator._ValueReferenceResolver
> and possibly also in other wrappers.
> This leads to throwing MethodNotFound Exceptions because we do not delegate
> the invoke invocation to the wrapped ELResolver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
