Hi
There is an issue open related to checkResourceExists() call:
MYFACES-2628 Facelets ResourceSolver cant work : Make this call crash
facelets ResourceSolver, it was suggested this issue.
The previous evidence suggest the following line:
ViewDeclarationLanguage vdl =
viewHandler.getViewDeclarationLanguage(facesContext,
restoreViewSupport.deriveViewId(facesContext, viewId));
Is the problem. The documentation says this about
getViewDeclarationLanguage:
"....Return the ViewDeclarationLanguage instance used for this ViewHandler
instance.
The default implementation must use
ViewDeclarationLanguageFactory.getViewDeclarationLanguage(java.lang.String)
to obtain the appropriate ViewDeclarationLanguage implementation for the
argument viewId. Any exceptions thrown as a result of invoking that method
must not be swallowed.
The default implementation of this method returns null....."
In theory, getViewDeclarationLanguage(facesContext, viewId) receive the
viewId after derive it, but the evidence suggest here we could receive the
rawViewId, so getViewDeclarationLanguage() should do the required steps to
derive the view id without call checkResourceExists(). I'll do some tests to
see what happen.
regards,
Leonardo Uribe
2010/8/2 Matthias Wessendorf <[email protected]>
> UIInput is slow, we already have bugs for that
>
> -Matthias
>
> On Mon, Aug 2, 2010 at 7:18 PM, Jan-Kees van Andel
> <[email protected]> wrote:
> > Hey,
> > I'm very interested in the details behind those 750ms. Can you post
> > the hotspots? Like: number of invocations, ms. self time and ms. total
> time.
> > Thanks.
> > Regards,
> > Jan-Kees
> >
> > 2010/8/2 Martin Koci <[email protected]>
> >>
> >> Hi,
> >>
> >> our profiling results show that myfaces are significantly slower in
> >> restore view phase:
> >>
> >> com.sun.faces.... LifeCycle .. restoreView : 80 ms
> >>
> >> o.a.m.RestoreViewExecutor : 750ms!
> >>
> >> This result is perfectly reproducible in our case. I profile it on a
> >> application real application - I cannot post test case here.
> >>
> >> Configuration: myfaces or mojarra from trunk, partial state saving, a
> >> view with more than 200 UIInput components.
> >>
> >>
> >> Is it a known problem? I will provide more detailed profiling results
> >> later.
> >>
> >> Regards,
> >>
> >> Martin Kočí
> >>
> >>
> >>
> >>
> >>
> >
> >
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
