[
https://issues.apache.org/jira/browse/MYFACES-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895230#action_12895230
]
Werner Punz commented on MYFACES-2858:
--------------------------------------
I have isolated most of the scripts, from what I can see is there is no direct
event handling messed up, but what could be is that the autoscroll feature does
something in that case, do you have a bugreport on the issue?
But there is one section from what I can gather which never worked, that was
that one
//this never worked in our code because version never was defined, I will drop
it for now, since no one uses
//it anyway
//if (agentString.indexOf('msie') != -1) {
// if (!(agentString.indexOf('ppc') != -1 &&
agentString.indexOf('windows ce') != -1 && version >= 4.0) && window.external
&& window.external.AutoCompleteSaveForm) {
// window.external.AutoCompleteSaveForm(form);
// }
//}
(I commented that out) it sort of was a special context param which when
enabled triggered autosave in older ie versions on input params, probably
absolutely no one has used it, otherwise they would have stepped on following
error:
gentString.indexOf('windows ce') != -1 && version >= 4.0)
the version var never was defined and probably would have caused an error. But
the good thing is this code only was activated via a context param.
Nevertheless externalizing all this should be prio #1 it reduces the page size
by about 8kbyte on every request!!! and also makes the code more maintainable.
> pointless oamsubmit inline rendering
> ------------------------------------
>
> Key: MYFACES-2858
> URL: https://issues.apache.org/jira/browse/MYFACES-2858
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.2-SNAPSHOT
> Reporter: Werner Punz
>
> We have had several functions rendered inline for ages, namely
> appendHiddenInput oamSubmit, the autoscroll stuff etc...
> I personally think the rendering of those functions as inline scripts is
> pointless, blows up the browsers tremendously and
> prevents that the affected scripts can be browser cached.
> A quick look at the code revealed that there is basically nothing which would
> prevent to externalize the scripts. My main problem is where to we handle the
> auto append code.
> My personal guess is we probably simply should add it as a resource
> definitions to the commandLink, Button etc.. renderers, any ideas regarding
> this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
