On Tue, Aug 10, 2010 at 9:29 PM, Andy Schwartz <[email protected]> wrote: > Gang - > > Blake implemented client id caching back in March (r921628 on > trinidad-1.2.x). However, this behavior was intentionally left > disabled by default in order to allow testing to occur before we turn > this on. I would like to propose that we now enable this > functionality by default. This will: > > - Improve our out of the box performance. And... > - Bring UIXComponentBase.getClientId() in line with > UIComponentBase.getClientId() implementations (both Mojarra and > MyFaces).
+1 > > I have attached a patch to issue 1669: > > https://issues.apache.org/jira/secure/attachment/12451699/trinidad-1669.patch small comment. For the JSF2 version, should we log a warning in case the ProjectStage is PRODUCTION, but the CLIENT_ID_CACHING prop is OFF/DEBUG ? -Matthias > > Which implements this change. It also exposes a new > "org.apache.myfaces.trinidad.CLIENT_ID_CACHING" system property that > can be used to disable this functionality - which generally should not > be necessary - but could come in handy for debugging purposes. > > Would appreciate it if folks here could review. > > Thanks! > Andy > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
